Wp 579 request extensions form #332
Open
+364
−471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandra-tacc
approved these changes
Oct 16, 2024
| <hr /> | ||
| <h4>Request and Justification</h4> | ||
| <FormGroup> | ||
| <Label for="justification"> |
There was a problem hiding this comment.
for accessibility - htmlFor is suggested instead of for
Suggested change
| <Label for="justification"> | |
| <Label htmlFor="justification"> |
| Applicable Data Period <sup>1</sup> | ||
| <span className={styles.requiredText}>{" "}(required)</span> | ||
| </Label> | ||
| <Field as="select" name={`extensions.${index}.applicableDataPeriod`} className="form-control"> |
There was a problem hiding this comment.
Some fields are missing id attribute that Label for or htmlFor will look at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Convert Request Extension form to react
Related
Changes
Added ExtensionForm React component
Testing
UI
Notes