Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception list React implementation #329

Open
wants to merge 7 commits into
base: feat/apcd-react-conversion
Choose a base branch
from

Conversation

jmartinez-tacc
Copy link

Overview

Exception list React implementation

Related

WP-635

Changes

Exception list and modals conversion.

Testing

  1. Navigate to http://localhost:8000/administration/list-exceptions/
  2. Select filters and make sure those filters are applied to the Exceptions list
  3. From Actions drop-down select View Record, make sure the information is displayed
  4. From Actions drop-down select Edit Record, make sure the information is updated and changes are reflected on View Record modal window and listing

UI

Screenshot 2024-10-15 at 2 52 25 PM Screenshot 2024-10-15 at 2 52 42 PM Screenshot 2024-10-15 at 2 52 58 PM Screenshot 2024-10-15 at 2 53 08 PM

Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit modal for exception has differences between localhost and dev.apcd.

There is header and field list is different in dev and production. See below
Screenshot 2024-10-16 at 10 27 53 AM

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM here are some ideas for styling. May be a good idea as a follow on to eventually factor out global element styles (modal, input, table, etc) so that all table listing, form fields, and modals start with the same basic layout and then have that sheet applied to main.tsx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some styles currently being applied to the modal and listing part of the page before your style module (EditExceptionModal.module.css) https://github.com/TACC/Core-CMS-Custom/tree/main/apcd_cms/src/apps/admin_exception/static/admin_exception/css

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some styles currently being applied to the modal that could be conflicting with is. https://github.com/TACC/Core-CMS-Custom/tree/main/apcd_cms/src/apps/admin_exception/static/admin_exception/css

@@ -1,65 +1,11 @@
{% extends "apcd_cms/templates/standard.html" %}
{% load static %}
<link rel="stylesheet" href="{% static 'apcd-cms/css/modal.css' %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of your style modules (ViewExceptionModal.module.css in this case) may be clashing with these stylesheets here and might be why the modals don't look the same as dev/staging/prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants