Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WP-197 migrate frontera portal #293

Open
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 9, 2024

Overview

Migrate Frontera project from Core-CMS-Resources.

Status

Related

Changes

Testing

  1. npm ci
  2. npm run build
  3. Verify no errors.
  4. Deploy to a Frontera staging server.
  5. Add snippet to Home page:
    <style>
    @import url("https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@feat/WP-197-migrate-frontera/frontera_assets/css/build/template.home.css");
    </style>
  6. Change Home page template to "(Core-CMS) Full Width".
  7. Add snippet to System page:
    <style>
    @import url("https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@feat/WP-197-migrate-frontera/frontera_assets/css/build/template.standard.css");
    </style>
  8. Change System page template to "(Core-CMS) Standard".
  9. Verify no undocumented style differences123 from production site:

UI

Before (Prod) After (Test)
home fp prod home fp test home
system fp prod system fp test system
training fp prod training fp test training

Notes

Warning

Loads Core-CMS stylesheet at a version that will not auto-sync with version of Core-CMS being run.

Important

  • On Home and System pages, some font weight is thinner.1 See Core-Styles v2.26.1.
  • On Home page, background behind articles in banner is less gray. This is a fix to a production bug.3
Completed Tasks
  • fix problems
    • fix different fonts on "Full Width" pages (before 5e1fb7c)
    • fix error loading v1_v2.css (since 5e1fb7c)
    • fix homepage explosion of failed styles
    • fix s-article-list "See all …" / "Learn …" link arrow icon wrong
    • fix s-article-list "Learn …" link arrow color swap
    • fix System Monitor "Operational" pill icon, remove or fix
    • System page with "(Core CMS) …" template, typography is wrong
    • un-migrated page with "(Core CMS) …" template, CMS nav links are blue
    • migrated page with "… Full Width" template, CMS nav links are blue
    • System page <h3> is much thinner (like a Core-Styles v0 site)
  • reduce necessity of CSS build process
    • use @mixin not @extend
    • set banner without config script (pass buildId to in options)
    • move archived BentonSans fonts to frontera_assets
    • fix layout (padding-left) of elements in header nav
  • update/add README's

Footnotes

  1. Expected style differences: some slightly thinner font weight, icon on system monitor status pill. 2

  2. Content is expected to be different, but within the same layout. Some home page news images on staging do not load (because they hotlink to old TACC site).

  3. Homepage background behind articles in banner should be less gray than production. (This fixes a production bug.) 2

@wesleyboar wesleyboar changed the title feat(frontera): WP-19 migrate feat: WP-19 migrate frontera portal Jul 9, 2024
@wesleyboar wesleyboar changed the title feat: WP-19 migrate frontera portal feat: WP-197 migrate frontera portal Jul 9, 2024
@wesleyboar wesleyboar force-pushed the feat/WP-197-migrate-frontera branch from 833a53c to 31bc419 Compare July 25, 2024 17:58
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Jul 25, 2024
Frontera migration —
TACC/Core-CMS-Custom#293
— uses @layers, but then Frontera styles yield to Core-CMS styles.

They yield because Core-CMS —
with `TACC_CORE_STYLES_VERSION=2`
— has all its styles in an anonymous layer.

(CSS in an anonymous layer beats CSS in a named layer.)
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Jul 25, 2024
Frontera migration —
TACC/Core-CMS-Custom#293
— uses @layers, but then Frontera styles yield to Core-CMS styles.

They yield to Core-CMS because Core-CMS —
with `TACC_CORE_STYLES_VERSION=0`
— has all its styles in an anonymous layer.

(CSS in an anonymous layer beats CSS in a named layer.)
@wesleyboar wesleyboar marked this pull request as ready for review September 27, 2024 22:54
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Oct 1, 2024
* feat: WP-197 use @layer's / help migrate Frontera

Frontera migration —
TACC/Core-CMS-Custom#293
— uses @layers, but then Frontera styles yield to Core-CMS styles.

They yield to Core-CMS because Core-CMS —
with `TACC_CORE_STYLES_VERSION=0`
— has all its styles in an anonymous layer.

(CSS in an anonymous layer beats CSS in a named layer.)

* fix: #s-header .nav-link hover underline

* fix: #s-header .nav-link hover underline for real

* chore: rename override-v4…

* fix: site.css overrides boostrap navbar pad…left

* fix: layer project overwrites `project.migration`

So, change `project` to `project.core`.

* fix: bootstrap 3 styles overriding header

* fix: header fix missing on new core-styles v1 site

Recent CSS fix for header was only applied to v1-origin sites.

The fix should be applied to v4.18+ sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant