-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #58 Privacy Provider #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few very minor things and then I can accept this pull request. Thanks for your work!
classes/privacy/provider.php
Outdated
|
||
/** | ||
* Privacy Subsystem for tool_coursearchiver implementing null_provider. | ||
* | ||
* @copyright 2015 Matthew Davidson | ||
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
*/ | ||
class provider implements \core_privacy\local\metadata\null_provider { | ||
class provider implements \core_privacy\local\request\data_provider, \core_privacy\local\metadata\provider { | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 1 space before /**
@@ -26,6 +26,9 @@ | |||
|
|||
// Privacy strings. | |||
$string['privacy:metadata'] = 'The plugin does not contain user data.'; | |||
$string['privacy:metadata:tool_coursearchiver'] = 'Data related to users that optouts.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optouts -> optout
lang/en/tool_coursearchiver.php
Outdated
@@ -26,6 +26,9 @@ | |||
|
|||
// Privacy strings. | |||
$string['privacy:metadata'] = 'The plugin does not contain user data.'; | |||
$string['privacy:metadata:tool_coursearchiver'] = 'Data related to users that optouts.'; | |||
$string['privacy:metadata:tool_coursearchiver_optout:userid'] = 'Id of user who opted out.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id -> ID
5acb832
to
0691d46
Compare
Added privacy provider fix