Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include other-code source-ref in some compiler error messages #235

Closed
wants to merge 5 commits into from

Conversation

nachumg
Copy link
Contributor

@nachumg nachumg commented Nov 30, 2024

Implements #231

@nachumg
Copy link
Contributor Author

nachumg commented Nov 30, 2024

Hi, why does it fail:

  1. python 3.5 - https://github.com/SystemRDL/systemrdl-compiler/actions/runs/12098641358/job/33735331485?pr=235 - what did I break?

  2. mypy - I didn't change those files that it is complaining about - do you want me to fix those in a separate change?

@coveralls
Copy link

Coverage Status

coverage: 94.653% (-0.2%) from 94.826%
when pulling 817f5ff on nachumg:main
into 649519b on SystemRDL:main.

@amykyta3
Copy link
Member

amykyta3 commented Jan 3, 2025

Not quite. the ref variable you are using is not the same as src_ref.
Either way, I have implemented this in a separate commit and will close this PR.

@amykyta3 amykyta3 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants