Skip to content

Commit 2631e94

Browse files
committed
doc updates
1 parent de57816 commit 2631e94

File tree

4 files changed

+21
-15
lines changed

4 files changed

+21
-15
lines changed

docs/best-practices.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Only use the global lexical scope if you want to declare common components that
77
you intend to use globally. This avoids polluting the global namespace and
88
prevents unexpected component name collisions.
99

10-
Bad:
10+
|:thumbsdown:| Bad:
1111

1212
.. code:: systemrdl
1313
@@ -24,7 +24,7 @@ Bad:
2424
my_status_reg status;
2525
};
2626
27-
Good:
27+
|:thumbsup:| Good:
2828

2929
.. code:: systemrdl
3030

docs/conf.py

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
extensions = [
3333
'sphinx.ext.autodoc',
3434
'sphinx.ext.napoleon',
35+
'sphinxemoji.sphinxemoji',
3536
]
3637

3738
# Add any paths that contain templates here, relative to this directory.

docs/requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
pygments-systemrdl
22
sphinx-book-theme
3+
sphinxemoji

docs/style-guide.rst

+17-13
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ parameter lists, or anything else between braces: ``{``, ``}``, ``(``, ``)``,
2323
Keep indentation consistent
2424
---------------------------
2525

26-
Yes:
26+
|:thumbsup:| Yes:
2727

2828
.. code:: systemrdl
2929
@@ -33,7 +33,7 @@ Yes:
3333
hw = r;
3434
} my_field;
3535
36-
No:
36+
|:thumbsdown:| No:
3737

3838
.. code:: systemrdl
3939
@@ -51,7 +51,7 @@ The closing brace ``}`` must be on a line of its own along with its instance
5151
name if appropriate.
5252

5353

54-
Yes:
54+
|:thumbsup:| Yes:
5555

5656
.. code:: systemrdl
5757
@@ -61,7 +61,7 @@ Yes:
6161
hw = r;
6262
} my_field;
6363
64-
No:
64+
|:thumbsdown:| No:
6565

6666
.. code:: systemrdl
6767
@@ -75,6 +75,8 @@ No:
7575
7676
If a component has a parameter list, parentheses use the same convention:
7777

78+
|:thumbsup:|
79+
7880
.. code:: systemrdl
7981
8082
field my_field #(
@@ -98,13 +100,13 @@ Where to add spaces
98100
On both sides of any assignment or expression operators
99101
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
100102

101-
Yes:
103+
|:thumbsup:| Yes:
102104

103105
.. code:: systemrdl
104106
105107
reset = 4 + MY_PARAM / 2;
106108
107-
No:
109+
|:thumbsdown:| No:
108110

109111
.. code:: systemrdl
110112
@@ -113,15 +115,15 @@ No:
113115
Before and after open/close braces
114116
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
115117

116-
Yes:
118+
|:thumbsup:| Yes:
117119

118120
.. code:: systemrdl
119121
120122
field {
121123
desc = "My field";
122124
} my_field;
123125
124-
No:
126+
|:thumbsdown:| No:
125127

126128
.. code:: systemrdl
127129
@@ -139,7 +141,7 @@ In most cases, keep each property assignment on its own distinct line.
139141
Since properties ``sw`` and ``hw``, are nearly always used together, it is
140142
acceptable to stack them on the same line.
141143

142-
Yes:
144+
|:thumbsup:| Yes:
143145

144146
.. code:: systemrdl
145147
@@ -151,7 +153,7 @@ Yes:
151153
onread = rclr;
152154
} my_field;
153155
154-
No:
156+
|:thumbsdown:| No:
155157

156158
.. code:: systemrdl
157159
@@ -161,7 +163,7 @@ No:
161163
} my_field;
162164
163165
164-
Acceptable:
166+
|:thumbsup:| Acceptable:
165167

166168
.. code:: systemrdl
167169
@@ -177,7 +179,7 @@ Component type and instance names are lowercase
177179
-----------------------------------------------
178180
There is no need to yell.
179181

180-
Yes:
182+
|:thumbsup:| Yes:
181183

182184
.. code:: systemrdl
183185
@@ -187,7 +189,7 @@ Yes:
187189
188190
my_field inst;
189191
190-
No:
192+
|:thumbsdown:| No:
191193

192194
.. code:: systemrdl
193195
@@ -211,6 +213,8 @@ Break long descriptions into multiple lines, indented at the same level as the
211213
scope it is in.
212214
Start and end quotation marks use the same rules as braces.
213215

216+
|:thumbsup:|
217+
214218
.. code:: systemrdl
215219
216220
field {

0 commit comments

Comments
 (0)