Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce dependency #312

Merged
merged 2 commits into from
May 13, 2022
Merged

fix: reduce dependency #312

merged 2 commits into from
May 13, 2022

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented May 13, 2022

Main improvements in this PR:

  • Fix:
    • Remove COBRA Toolbox and MATLAB-git dependencies
  • Refactor:
    • Change format of yeast-GEM.txt file to include metabolite names and compartments, instead of metabolite identifiers, to simplify diff-ing (metabolite identifiers are already trackable in the yml-file)

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected develop as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@edkerk edkerk marked this pull request as ready for review May 13, 2022 16:33
@edkerk edkerk merged commit 466f2eb into develop May 13, 2022
@edkerk edkerk deleted the fix/reduceDependency branch May 13, 2022 16:33
@edkerk edkerk mentioned this pull request May 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edkerk