-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/interOSissues #117
fix/interOSissues #117
Conversation
regardless if the model is saved with a windows or a MAC machine, the .xml file is now stored with the same scientific format
@hongzhonglu can you test this in your OS? in this branch, go through a I/O cycle and let me know if any model files are changing |
@BenjaSanchez I will do it today! |
updated COBRA and libSBML, with no content changes
for avoid undesired changes, it will now only match the format `-00N`, where N is a number 0-9.
matches only "Me-00N", where M and N are numbers 0-9
Hello, Benjamin,
This is the test result when run the I/O cycle I OS:
[cid:[email protected]]
[cid:[email protected]]
Best regards,
Hongzhong
|
@hongzhonglu I think images cannot be pasted when you reply via email, as I cannot see the results. Are any of the model files changing? Also note that I did a couple of extra commits in the afternoon, so before you try it make sure to pull all changes |
One place in xml file has been changed.
Best regards,
Hongzhong
|
@hongzhonglu could you show me how did it change? did you do it with the latest version of this branch? if you reply in Github you can embed pictures |
@BenjaSanchez |
@hongzhonglu you have to switch to branch |
@BenjaSanchez You can find the latest test. |
This reverts commit 491581a.
Main improvements in this PR:
Addresses issue #96: regardless if the model is saved with a windows or a MAC machine, the .xml file is now stored with the same scientific format
I hereby confirm that I have:
devel
as a target branch (top left drop-down menu)