Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/interOSissues #117

Merged
merged 8 commits into from
Jun 4, 2018
Merged

fix/interOSissues #117

merged 8 commits into from
Jun 4, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

Addresses issue #96: regardless if the model is saved with a windows or a MAC machine, the .xml file is now stored with the same scientific format

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

regardless if the model is saved with a windows or a MAC machine, the .xml file is now stored with the same scientific format
@BenjaSanchez BenjaSanchez added the format fix things associated to format of any of the model/data/script files label May 30, 2018
@BenjaSanchez BenjaSanchez requested a review from hongzhonglu May 30, 2018 07:55
@BenjaSanchez
Copy link
Contributor Author

@hongzhonglu can you test this in your OS? in this branch, go through a I/O cycle and let me know if any model files are changing

@hongzhonglu
Copy link
Collaborator

@BenjaSanchez I will do it today!

@BenjaSanchez BenjaSanchez mentioned this pull request May 30, 2018
4 tasks
updated COBRA and libSBML, with no content changes
for avoid undesired changes, it will now only match the format `-00N`, where N is a number 0-9.
matches only "Me-00N", where M and N are numbers 0-9
@hongzhonglu
Copy link
Collaborator

hongzhonglu commented May 30, 2018 via email

@BenjaSanchez
Copy link
Contributor Author

BenjaSanchez commented May 30, 2018

@hongzhonglu I think images cannot be pasted when you reply via email, as I cannot see the results. Are any of the model files changing?

Also note that I did a couple of extra commits in the afternoon, so before you try it make sure to pull all changes

@hongzhonglu
Copy link
Collaborator

hongzhonglu commented May 30, 2018 via email

@BenjaSanchez
Copy link
Contributor Author

@hongzhonglu could you show me how did it change? did you do it with the latest version of this branch? if you reply in Github you can embed pictures

@hongzhonglu
Copy link
Collaborator

@BenjaSanchez
These are changes in the test:
image
image
I use latest branch of dev, load model and then save the model.

@BenjaSanchez
Copy link
Contributor Author

@hongzhonglu you have to switch to branch fix/interOSissues (and pull all recent changes), as the changes are there. devel does not have any of the changes in this PR yet.

@hongzhonglu
Copy link
Collaborator

@BenjaSanchez You can find the latest test.

@BenjaSanchez BenjaSanchez merged commit 5988973 into devel Jun 4, 2018
@BenjaSanchez BenjaSanchez deleted the fix/interOSissues branch June 10, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format fix things associated to format of any of the model/data/script files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants