Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs preventing the pipeline to run #94

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mihai-sysbio
Copy link
Member

Starting off with a simple rename, the work in this PR started by making sure the pipeline runs as intended. In the end this PR aims to do a few more things:

  • handle the renaming of the branch master to main. In this process, the branch develop has been discarded and is not intended to be used.
  • fix a minor bug regarding the Gurobi path
  • fix the renaming of a compartment abbreviation that is used in a script preprocessing the Human-GEM
  • handle the case that for Kluyveromyces_marxianus-GEM the default branch on GitHub is still master
  • fix a bug that prevented the pipeline to run on non-default GECKO branches

Due to a known bug in the command-line tool hub, it is expected for the pipeline to run but to not produce the expected PRs. This issue, reported as #93, will be resolved in an independent PR.

@mihai-sysbio mihai-sysbio added the bug Something isn't working label Jul 1, 2022
@mihai-sysbio
Copy link
Member Author

mihai-sysbio commented Jul 3, 2022

Even though it was mentioned above that this PR would not address the hub fix, I have attempted a fix by switching from the unofficial hub to the official gh CLI, with the hopes that would allow the Action to complete. If it still does not, I will remove that commit and un-draft the current PR.

@mihai-sysbio mihai-sysbio marked this pull request as draft July 3, 2022 08:34
@mihai-sysbio
Copy link
Member Author

mihai-sysbio commented Jul 4, 2022

The fix introduced in 1b1867c worked. Now that the pipeline is fully functional, this PR should be merged in with priority.

@mihai-sysbio mihai-sysbio marked this pull request as ready for review July 4, 2022 05:12
@mihai-sysbio
Copy link
Member Author

Forgot to mention above, this PR resolves #93 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant