fix: find toolbox version #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find version.txt with full path to avoid replicates
edkerk
requested changes
Oct 2, 2018
There was a problem hiding this comment.
If masterFlag is true, and a toolbox is not in master, then it doesn't give the relevant error message, but rather prints "RAVEN/COBRA toolbox cannot be found". The reason for this is that checkIfMaster is called within a try-catch block, so the error message triggered by checkIfMaster is not shown, while Matlab will jump to the catch section that prints "RAVEN/COBRA toolbox cannot be found".
if toolboxes are not in master and checkIfMaster=TRUE, the proper error message will be displayed
|
@edkerk thanks for spotting this. The latest commit fixes this issue, by doing things separately:
|
edkerk
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
A recent change in
exportForGit.m(PR #160) created a bug that duplicated the version number for RAVEN and COBRA (asfopenwill look up a file in all available paths if full path is not specified):To correct this,
version.txtis now opened with its full path. This was tested on yeast-GEM with the changes included locally in the master branch of RAVEN and works as expected:I hereby confirm that I have:
develas a target branch