Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In essential metabolic tasks: NEFA blood pool in[x] should be changed for NEFA blood pool in[s] #311

Closed
CadavidJoseL opened this issue Sep 1, 2021 · 5 comments

Comments

@CadavidJoseL
Copy link

Essential task 46 (Uptake and beta oxidation of all NEFAs) fails in version 1.9. NEFA blood pool in[x] should be changed for NEFA blood pool in[s]; this solves the issue.

@JonathanRob
Copy link
Collaborator

JonathanRob commented Sep 1, 2021

@CadavidJoseL Thanks for finding this, it should be changed to the [s] compartment as you suggest.

However, this task should not fail, even with the [x] compartment being used. Did you remember to add the boundary metabolites before running checkTasks?:

model_boundary = addBoundaryMets(model);
checkTasks(model_boundary, ...);

If the boundary metabolites are not present, then the task check results will not be valid.

@CadavidJoseL
Copy link
Author

You're right, I did forget to add those boundary mets; that also fixes the issue. Thanks!

@JonathanRob
Copy link
Collaborator

No problem, but I believe you are still correct in that the NEFA blood pool in compartment should be changed from [x] to [s] in the task file.

@JonathanRob
Copy link
Collaborator

If it's ok with you, @CadavidJoseL, I'd like to keep this issue open until we correct the compartment of the NEFA blood pool in in the task file. Otherwise we may forget to make the fix.

@JonathanRob JonathanRob reopened this Sep 14, 2021
@JonathanRob JonathanRob mentioned this issue Nov 5, 2021
2 tasks
@JonathanRob
Copy link
Collaborator

This issue was resolved in #331.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants