Conversation
fix slither crashing in ci and local #1519
* Adding safe functionality from the gnosis SDK to the owner command * Updating nominate command to use owner actions when not the owner
* Sargas to be OVM only with 135, 142 and 174 * Adding missing SIP-140 from list
* * conceptually document this function * iterate on a simplified construction * rewrite doc for current version, sans changes to logic * document debt cache
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
* chore: name entry added to lockfile in recent npm version * ci: update docker containers to node@14.18
* update deployer to support EIP-1559 updates `--gas-price` to be replaced with `--max-fee-per-gas` which specifies the maximum base fee paid on a transaction. Additionally, deployer may also specify `--max-priority-fee-per-gas` to specify a mining tip (default: 1 gwei) If the network does not support 1559, the `gasPrice` is automatically determined by ethers. For EIP-1559 support, ethers.js needed to be upgraded to 5.4.6 Co-authored-by: jj <jj@og.snxdao.io>
* fix partial synth updates and debt cache updates * Remove require check that cachedSum < Debt as excluded Debt can cause this to fail. Update calc of delta in new synths changed.
Co-authored-by: Lecky <leckylao@gmail.com> Co-authored-by: Mark Barrasso <4982406+barrasso@users.noreply.github.com>
* fix test lints sometimes the dual tests fail due to race condition built into the tests in addition, a better event is now being used for monitoring transaction relay status. Withdrawal tests still don't work because the transaction is not relayed on the L1 side, I'm guessing because the user has to call `finalize` transaction somehow. Not sure who to talk to if we want to get those tests working. * fix lints * uncomment Co-authored-by: Mark Barrasso <4982406+barrasso@users.noreply.github.com> Co-authored-by: jj <jj@og.snxdao.io>
* update migration script to also stage nominations also the owner can now run migration, instead of the deployer, which is way better for getting stuff done * fix lints * re-add legacy onlyDeploy function for older migrations * add verify step * use performTransactionalStep * add signer * cleanup verify step and additional logging for clarity
# Conflicts: # package-lock.json # publish/deployed/kovan-ovm/deployment.json # publish/deployed/mainnet-ovm/config.json # publish/deployed/mainnet-ovm/deployment.json # publish/releases.json # publish/src/commands/deploy-migration.js # publish/src/commands/deploy/deploy-core.js
* Also fix test-coverage in CI
# Conflicts: # hardhat/tasks/task-node.js # publish/releases.json # publish/src/commands/deploy-migration.js
# Conflicts: # contracts/migrations/Migration_Alphard.sol # contracts/migrations/Migration_AlphardOptimism.sol
Codecov Report
@@ Coverage Diff @@
## staging #1705 +/- ##
===========================================
- Coverage 95.12% 95.12% -0.01%
===========================================
Files 83 83
Lines 1991 1990 -1
Branches 621 620 -1
===========================================
- Hits 1894 1893 -1
Misses 97 97
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.