Feat/sip 184 merge develop#1640
Merged
leckylao merged 11 commits intofeat/sip-184-dynamic-feesfrom Jan 8, 2022
Merged
Conversation
- apply AtRound changes - Adding cacheRates on ExchangeRates
- Adding anyRateIsInvalidAtRound mock
- Add updateRatesWithDefaults to invoid invalid rate
- move setPriceAggregator out of the updateRates loop
- Fix set price with no volatility on exchangeAtomically
Codecov Report
@@ Coverage Diff @@
## feat/sip-184-dynamic-fees #1640 +/- ##
=============================================================
- Coverage 95.73% 95.68% -0.05%
=============================================================
Files 83 83
Lines 1945 1946 +1
Branches 609 610 +1
=============================================================
Hits 1862 1862
- Misses 83 84 +1
Continue to review full report at Codecov.
|
- remove format from cacheRate as it's already been formatted
- Having the rounds rate loop inside the aggregator
- Using roundId 1 for sUSD to be consistent - Fix interface wrong compiler version warning
- adding --max-old-space-size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.