Feat(SystemSettings): SIP-193 Reduce size for SystemSettings#1626
Closed
Feat(SystemSettings): SIP-193 Reduce size for SystemSettings#1626
Conversation
- created libraries folder - moving SafeDecimalMath into libraries
- adding decimals into SafeDecimalMath
- Adding dynamic fee constants;
- Adding require check for price; - Adding setup for test;
- Adding more rounds of price feeds for test; - Adding dynamic fee in systemSettings in test
- removed fastForward as startTime and Now is not equal
- Rename priceWeight to RoundDecay - adding cap 100% for max exchangeFeeRate - Added return for invalid rate - linking libraries in setup
…nthetix into feat/sip-184-dynamic-fees
- disable dynamic fee when price feeds less than 2 rounds - disable dynamic fee on exchanger spec settle
- Adding more rounds for rates
- Rollback as no cache for _getRateAndUpdatedTime
- Disable Dynamic fee on test with base exchange fee rate
- Adding more rounds on rates;
…nthetix into feat/sip-184-dynamic-fees
- Disable Dynamic fee in order for debt calculation
- Adding generateSolidity into configure-system-settings
- Adding MAX_DYNAMIC_FEE default to 1 - remove comment with system value - remove nonreentrant - removed swing trade double fee - created getExchangeDynamicFeeData for combine external call - _setRate skip writing if same rate
…mic fee - remove duplicated code in _calculateFeeRateFromExchangeSynths - Added test cases for up/down price differential
- Disable dynamic fee to neglect it in systemSettings
- change ConfigureSystemSettings to only change if zero
This reverts commit d0ccd74.
This reverts commit f75031a.
This reverts commit 77eed96.
Contributor
Author
|
Wrong init branch |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.