Fixing releases to also mark SIPs as released#1546
Merged
Conversation
jjgonecrypto
commented
Oct 4, 2021
| } | ||
|
|
||
| const prerelease = semver.prerelease(versionTag) && semver.prerelease(versionTag) !== 'ovm'; | ||
| const prerelease = semver.prerelease(versionTag) && semver.prerelease(versionTag)[0] !== 'ovm'; |
Contributor
Author
There was a problem hiding this comment.
this was the bug - semver.prerelease was returning an array
Codecov Report
@@ Coverage Diff @@
## staging #1546 +/- ##
========================================
Coverage 95.92% 95.92%
========================================
Files 75 75
Lines 1743 1743
Branches 547 547
========================================
Hits 1672 1672
Misses 71 71 Continue to review full report at Codecov.
|
dbeal-eth
reviewed
Oct 4, 2021
| } | ||
|
|
||
| const prerelease = semver.prerelease(versionTag) && semver.prerelease(versionTag) !== 'ovm'; | ||
| const prerelease = semver.prerelease(versionTag) && semver.prerelease(versionTag)[0] !== 'ovm'; |
Contributor
There was a problem hiding this comment.
are we certain that semver.prerelease(versionTag)[0] is not null? otherwise the functionality would not be exactly the same as before.
barrasso
approved these changes
Oct 4, 2021
Contributor
barrasso
left a comment
barrasso
left a comment
There was a problem hiding this comment.
LGTM, just have same concern that db raised about being certain the first element in the array is not null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layer-ovmwas being incorrectly skipped.