fix slither crashing in CI and local#1516
fix slither crashing in CI and local#1516artdgn wants to merge 2 commits intoSynthetixio:developfrom
Conversation
|
I don't how that's related to my changes. And fork-tests seems to have been broken before as well. |
Codecov Report
@@ Coverage Diff @@
## develop #1516 +/- ##
========================================
Coverage 95.47% 95.47%
========================================
Files 75 75
Lines 1744 1745 +1
Branches 545 545
========================================
+ Hits 1665 1666 +1
Misses 79 79
Continue to review full report at Codecov.
|
|
@justinjmoses CI is passing now (it's the third approach: not importing the OZ Math library at all). The added |
artdgn
force-pushed
the
develop
branch
5 times, most recently
from
7433b68 to
33cb9c9
Compare
|
Now the report is stored as a CI artifact, example |
details: slither was not working in both CI and running locally changes: - pass the correct artifacts path in config - avoid using OZ Math import to prevent name collision that was causing slither to fail - modify local slither target to install slither in virtual env instead of globally testing: local runs of slither, unit tests (`npx hardhat test --grep "Rewards"`)
|
Closed and replaced by #1519 |
1 participant
Context: was working through the different script targets and tests and this one was broken, so thought it might be nice to fix it.
Details: slither was not working in both CI and locally, example run. It seems it has been broken for a while (at least 4mo back, haven't check earlier).
changes:
testing: local runs of slither, unit tests (
npx hardhat test --grep "Rewards")