Merged
Conversation
this hsould fix fork tests and clear up the develop branch.
Codecov Report
@@ Coverage Diff @@
## develop #1515 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 76 76
Lines 1733 1733
Branches 557 557
========================================
Hits 1650 1650
Misses 83 83 Continue to review full report at Codecov.
|
* update package-lock to trigger CI wipe of optimism cache * add initial base fee to something low so its always affordable gas
this probably should be fixed by the OVM team ultimately (the `type` field is a (EIP-2718)[https://eips.ethereum.org/EIPS/eip-2718]). but for now this workaround allows tests to work
This reverts commit 8ba667c.
This reverts commit 123195e.
| blockGasLimit: 12e6, | ||
| allowUnlimitedContractSize: true, | ||
| gasPrice: GAS_PRICE, | ||
| hardfork: 'london', |
Contributor
There was a problem hiding this comment.
This is effectively the required fix.
Contributor
|
OK so changes I added:
|
jjgonecrypto
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this hsould fix fork tests and clear up the develop branch.
note: this PR is only a hotfix to unblock deployments from
develop, and the real changes which implement proper transaction handling are in the PR #1504 1559 supportfixes required: