Skip to content

hotfix for fork tests#1515

Merged
jjgonecrypto merged 22 commits intodevelopfrom
fix-fork-tests
Sep 22, 2021
Merged

hotfix for fork tests#1515
jjgonecrypto merged 22 commits intodevelopfrom
fix-fork-tests

Conversation

@dbeal-eth
Copy link
Copy Markdown
Contributor

@dbeal-eth dbeal-eth commented Sep 20, 2021

this hsould fix fork tests and clear up the develop branch.

note: this PR is only a hotfix to unblock deployments from develop, and the real changes which implement proper transaction handling are in the PR #1504 1559 support

fixes required:

  • hardhat mode = london in config (ensures compatibility with fork mode)
  • txn field type: 1 (prevents auto usage of EIP 1559 transactions by hardhat which cause errors with curernt code)
  • upgrade optimism to develop branch to capture latest hardhat (otherwise integration test fails with invalid txn error)
  • force refresh caches on ci

this hsould fix fork tests and clear up the develop branch.
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1515 (b02a122) into develop (bd54f4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1515   +/-   ##
========================================
  Coverage    95.21%   95.21%           
========================================
  Files           76       76           
  Lines         1733     1733           
  Branches       557      557           
========================================
  Hits          1650     1650           
  Misses          83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd54f4e...b02a122. Read the comment docs.

blockGasLimit: 12e6,
allowUnlimitedContractSize: true,
gasPrice: GAS_PRICE,
hardfork: 'london',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is effectively the required fix.

@jjgonecrypto
Copy link
Copy Markdown
Contributor

OK so changes I added:

  • Reverted most items back to their original status except the hardhat fork config to use london.
  • Fixed issue where checksum logic for CircleCI was being stripped out by mustache: 3575b17
  • Rebuilt the lockfile to force a new CI cache of the ops tool
  • Fixed the shorts integration tests to use a lower amount of sUSD (this was failing with Amount too large as the fork uses the protocolDAO's holdings of SNX which wasn't sufficient to enable minting a large amount of sUSD): edcbe8e
  • Upped the unit test timeout to 90s and minor changes to CollateralShort.js unit test to mitigate the 60s timeout that occurred during one CI run: f4036e1

@jjgonecrypto jjgonecrypto merged commit 2a3cd7e into develop Sep 22, 2021
@jjgonecrypto jjgonecrypto deleted the fix-fork-tests branch September 22, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants