Remove price update constraint from order flow#1468
Closed
liamzebedee wants to merge 1 commit intofutures-implementationfrom
Closed
Remove price update constraint from order flow#1468liamzebedee wants to merge 1 commit intofutures-implementationfrom
liamzebedee wants to merge 1 commit intofutures-implementationfrom
Conversation
13 tasks
Merged
Contributor
Author
|
Closed in favour of #1477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided on Tuesday in Discord that in order to proceed with resolving Synthetixio/issues#260, we would remove the price update constraint from order flow and use the spot price for order confirmation in futures.
To unblock the monsieur le frontend, this PR only removes logic, and doesn't refactor. I started on refactoring the submitOrder and confirmOrder into one func - there's a lot of work to be done in refactoring the code to work with instant confirms - eg.
canConfirmOrderandorderStatuscurrently rely on the submitted order in storage, whereas now we should be passing the order as an argument. Same with the tests, moving price updates up before the submitOrder.