Add L2 governance bridge relay temp circumvention#1438
Merged
eternauta1337 merged 20 commits intogovernance-bridgefrom Aug 17, 2021
Merged
Add L2 governance bridge relay temp circumvention#1438eternauta1337 merged 20 commits intogovernance-bridgefrom
eternauta1337 merged 20 commits intogovernance-bridgefrom
Conversation
This mixin adds an extension to be able to execute a function from a hardcoded address with an EOL
This method can only be executed by the temporary owner before the specified EOL date on contructor
mjlescano
changed the title
…into add-relay-backdoor
eternauta1337
approved these changes
Aug 16, 2021
Codecov Report
@@ Coverage Diff @@
## governance-bridge #1438 +/- ##
=====================================================
+ Coverage 95.56% 95.58% +0.01%
=====================================================
Files 83 84 +1
Lines 1917 1925 +8
Branches 632 635 +3
=====================================================
+ Hits 1832 1840 +8
Misses 85 85
Continue to review full report at Codecov.
|
i-stam
approved these changes
Aug 17, 2021
Contributor
jjgonecrypto
left a comment
jjgonecrypto
left a comment
There was a problem hiding this comment.
A few items left - nothing major
i-stam
suggested changes
Aug 17, 2021
i-stam
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the method
directRelayto theOwnerRelayOnOptimismcontract so we can directly execute any relayed method directly on L2, circumventing the governance bridge functionality. TheOwnerRelayOnOptimismcontract now has to be instantiated with a TempOwner, which is the only address allowed to execute thedirectRelaymethod, and an EOL date for this permission. This is just a temporary precaution in case we encounter a bug on the new governance bridge and avoid a potential loss ownership of all the relayed contracts.Notes
OwnerRelayOnOptimismand cannot be modified after that.TODO