Add gas reporting job parallelization on CI#1305
Merged
eternauta1337 merged 5 commits intodevelopfrom Jun 17, 2021
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to be able to generate gas reports on the parallelized unit tests job. To achieve that we have to be able to generate multiple gas reports and merge them later on a separate job.
Right now, gas reporting is done by 2 steps:
npx hardhat test --gas, which will generate the filegasReporterOutput.jsonif running on CInpx codechecks codechecks.unit.yml, which will generate atest-gas-used.logand upload it to CodechecksAnd, for implementing parallelization, this PR generates different
gasReporterOutput-N.jsonfiles, and then merges them into a single file to be able to upload it to codechecks using thenpx hardhat test:merge-gas-reports gasReporterOutput-*.jsoncommand.Pendings
gasReporterOutput.jsonfiles has different results compared when we generate it in a single run. This has to be fixed before merging this PR