Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close new network popup after switching networks #842

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Close new network popup after switching networks #842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e484c
Close new network popup after switching to it for the first time
duckception Aug 18, 2023
99c8009
Add TODO
duckception Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions commands/metamask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,18 @@ const metamask = {
mainPageElements.actionableMessage.closeButton,
);
}

// Closes "You have switched to [network]" popup.
// It appears if you connect to a new network for the first time.
if (
(await playwright
.metamaskWindow()
.locator(recipientPopupElements.popupCloseButton)
.count()) > 0
) {
await playwright.waitAndClick(recipientPopupElements.popupCloseButton);
}

return true;
},
async closeModal() {
Expand Down Expand Up @@ -1219,6 +1231,10 @@ const metamask = {
notificationPage,
{ waitForEvent: 'close' },
);

// TODO: Add test for the new network popup. Requires changes to the MetaMask Test Dapp.
await module.exports.closePopupAndTooltips();

return true;
},
async rejectToSwitchNetwork() {
Expand Down