Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multicall for Optimism #133

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Fix Multicall for Optimism #133

merged 2 commits into from
Jan 5, 2025

Conversation

noisekit
Copy link
Contributor

@noisekit noisekit commented Jan 5, 2025

Trusted multicall forwarder had different signature, also we require to use TMF to do all the approvals in one multicall.

@noisekit noisekit self-assigned this Jan 5, 2025
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 4:14am

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (f3c28dc) to head (8f717f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...racts/importers/importTrustedMulticallForwarder.ts 0.00% 2 Missing ⚠️
...y/lib/useManagePermissions/useManagePermissions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   65.65%   65.30%   -0.35%     
==========================================
  Files         265      265              
  Lines        6475     6477       +2     
  Branches     2109     2110       +1     
==========================================
- Hits         4251     4230      -21     
- Misses       2224     2247      +23     
Files with missing lines Coverage Δ
...MulticallForwarder/useTrustedMulticallForwarder.ts 100.00% <100.00%> (ø)
liquidity/lib/useAccounts/useAccounts.ts 96.66% <100.00%> (ø)
...ollateralPriceUpdates/useCollateralPriceUpdates.ts 93.47% <100.00%> (ø)
liquidity/lib/useRewards/useRewards.ts 98.87% <100.00%> (ø)
liquidity/lib/useSynthBalances/useSynthBalances.ts 90.90% <100.00%> (ø)
liquidity/lib/useV2Position/useV2Position.ts 100.00% <100.00%> (ø)
liquidity/lib/withERC7412/withERC7412.ts 67.46% <100.00%> (+14.09%) ⬆️
.../components/ClosePosition/ClosePositionOneStep.tsx 83.33% <100.00%> (ø)
...y/lib/useManagePermissions/useManagePermissions.ts 8.82% <0.00%> (ø)
...racts/importers/importTrustedMulticallForwarder.ts 46.15% <0.00%> (ø)

... and 20 files with indirect coverage changes

@noisekit noisekit merged commit 4ba1256 into master Jan 5, 2025
10 of 11 checks passed
@noisekit noisekit deleted the fix-op-multicall branch January 5, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant