Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings not showing properly. #130

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Warnings not showing properly. #130

merged 1 commit into from
Jan 3, 2025

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Jan 3, 2025

When changing the deposit amount sometimes the warnings doesn't show up correctly:
Screenshot 2025-01-03 at 2 24 56 PM
(Here there should be a minimum deposit amount warning)
Checked the open state and it was set correctly so no issue with the form logic.

Seems like the issue is with the collapse component:
chakra-ui/chakra-ui#2534

This comment fixed the bug:
chakra-ui/chakra-ui#2534 (comment)

@peiman3 peiman3 added the bug Something isn't working label Jan 3, 2025
@peiman3 peiman3 requested a review from noisekit January 3, 2025 10:57
@peiman3 peiman3 self-assigned this Jan 3, 2025
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:57am

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (bb1318f) to head (f0ea125).

Files with missing lines Patch % Lines
...uidity/ui/src/components/Migration/StepSummary.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   66.27%   66.24%   -0.04%     
==========================================
  Files         265      265              
  Lines        6487     6487              
  Branches     2114     2114              
==========================================
- Hits         4299     4297       -2     
- Misses       2188     2190       +2     
Files with missing lines Coverage Δ
...quidity/components/ContractError/ContractError.tsx 75.00% <ø> (ø)
liquidity/ui/src/components/Claim/Claim.tsx 77.08% <100.00%> (ø)
.../ui/src/components/ClosePosition/ClosePosition.tsx 100.00% <ø> (ø)
liquidity/ui/src/components/Deposit/Deposit.tsx 98.07% <100.00%> (ø)
...quidity/ui/src/components/MigrateUSD/StepIntro.tsx 5.26% <ø> (ø)
...uidity/ui/src/components/Undelegate/Undelegate.tsx 89.04% <100.00%> (ø)
liquidity/ui/src/components/Withdraw/Withdraw.tsx 97.87% <100.00%> (ø)
...uidity/ui/src/components/Migration/StepSummary.tsx 2.17% <0.00%> (ø)

... and 2 files with indirect coverage changes

@noisekit noisekit merged commit 86e028b into master Jan 3, 2025
11 checks passed
@noisekit noisekit deleted the collapse-issue branch January 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants