Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionManager for Repay #129

Merged
merged 3 commits into from
Jan 6, 2025
Merged

PositionManager for Repay #129

merged 3 commits into from
Jan 6, 2025

Conversation

noisekit
Copy link
Contributor

@noisekit noisekit commented Jan 3, 2025

  1. Update Mainnet and Arbitrum to 1 click Repay with PositionManager contract
  2. Update e2e Repay tests to inspect debt values before and after transaction
  3. Allow to override RPCs for e2e tests

@noisekit noisekit self-assigned this Jan 3, 2025
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 4:42am

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 81.67939% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.11%. Comparing base (4ba1256) to head (f1d0325).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
liquidity/lib/etherscanLink/etherscanLink.ts 37.50% 10 Missing ⚠️
liquidity/ui/src/components/Repay/Repay.tsx 72.41% 8 Missing ⚠️
liquidity/ui/src/components/Repay/RepayModal.tsx 84.84% 5 Missing ⚠️
liquidity/components/RepayModal/RepayModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   66.41%   65.11%   -1.31%     
==========================================
  Files         265      267       +2     
  Lines        6477     6573      +96     
  Branches     2110     2155      +45     
==========================================
- Hits         4302     4280      -22     
- Misses       2175     2293     +118     
Files with missing lines Coverage Δ
liquidity/lib/useRepay/useRepay.tsx 92.85% <100.00%> (+6.85%) ⬆️
...onents/ClosePosition/ClosePositionTransactions.tsx 76.00% <100.00%> (-0.48%) ⬇️
...quidity/ui/src/components/Manage/ManageActions.tsx 53.91% <100.00%> (+0.75%) ⬆️
liquidity/components/RepayModal/RepayModal.tsx 0.00% <0.00%> (-67.37%) ⬇️
liquidity/ui/src/components/Repay/RepayModal.tsx 84.84% <84.84%> (ø)
liquidity/ui/src/components/Repay/Repay.tsx 77.19% <72.41%> (-14.92%) ⬇️
liquidity/lib/etherscanLink/etherscanLink.ts 37.50% <37.50%> (ø)

... and 8 files with indirect coverage changes

@noisekit noisekit merged commit cb3e43b into master Jan 6, 2025
10 of 11 checks passed
@noisekit noisekit deleted the position-manager branch January 6, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant