Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim success banner on mainnet #109

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Claim success banner on mainnet #109

merged 6 commits into from
Dec 18, 2024

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Dec 16, 2024

Screenshot 2024-12-17 at 2 14 56 AM

@peiman3 peiman3 added the enhancement New feature or request label Dec 16, 2024
@peiman3 peiman3 requested a review from noisekit December 16, 2024 22:45
@peiman3 peiman3 self-assigned this Dec 16, 2024
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:45pm

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (858cb79) to head (82d73ee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
liquidity/components/ClaimModal/ClaimModal.tsx 28.57% 10 Missing ⚠️
...idity/components/ClaimModal/ClaimSuccessBanner.tsx 0.00% 2 Missing ⚠️
...rc/components/MigrateUSD/MigrateUSDTransaction.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   67.17%   67.08%   -0.10%     
==========================================
  Files         259      260       +1     
  Lines        6346     6358      +12     
  Branches     2051     2055       +4     
==========================================
+ Hits         4263     4265       +2     
- Misses       2083     2093      +10     
Files with missing lines Coverage Δ
...idity/components/ClaimModal/ClaimSuccessBanner.tsx 0.00% <0.00%> (ø)
...rc/components/MigrateUSD/MigrateUSDTransaction.tsx 0.00% <0.00%> (ø)
liquidity/components/ClaimModal/ClaimModal.tsx 62.50% <28.57%> (-6.02%) ⬇️

... and 3 files with indirect coverage changes

@noisekit noisekit merged commit 3b76c57 into master Dec 18, 2024
8 of 10 checks passed
@noisekit noisekit deleted the mint-popup branch December 18, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants