Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (64.28%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
dnut
force-pushed
the
dnut/conformance/agave-4.0
branch
from
b8471ed to
b5b4692
Compare
InKryption
force-pushed
the
dnut/conformance/agave-4.0
branch
from
aba66b7 to
b1883d8
Compare
InKryption
previously approved these changes
Mar 19, 2026
3 rekeyed features: - account_data_direct_mapping -> CR3dVN2Yoo95Y96kLSTaziWDAQT2MNEpiWh5cqVq2pNE - enable_sbpf_v3_deployment_and_execution -> 5cC3foj77CWun58pC51ebHFUWavHWKarWyR5UUik7dnC - reenable_zk_elgamal_proof_program -> zkexuyPRdyTVbZqEAREueqL2xvvoBhRgth9xGSc1tMN 19 new features: - syscall_parameter_address_restrictions - virtual_address_space_adjustments - delay_commission_updates - create_account_allow_prefund - alt_bn128_little_endian - bls_pubkey_management_in_vote_account - enable_alt_bn128_g2_syscalls - commission_rate_in_basis_points - custom_commission_collector - set_lamports_per_byte_to_6333 - set_lamports_per_byte_to_5080 - set_lamports_per_byte_to_2575 - set_lamports_per_byte_to_1322 - set_lamports_per_byte_to_696 - limit_instruction_accounts - block_revenue_sharing - vote_account_initialize_v2 - validate_chained_block_id - validator_admission_ticket - alpenglow
…and a couple that broke?)
previously there were a bunch of scripts to manage these dependencies and it was getting difficult to maintain them and make them generally usable across different systems. nix flakes are intended for exactly this use case
with previous versions of solana conformance you couldn't use later than python 3.11 without getting errors. now we only see errors on 3.14. 3.13 is working
the test will fail if the outputs are incorrect. if we don't know the feature but our outputs are correct, then it doesn't matter for that test that we didn't know the feature. our code still passed the validations of that test, so it should pass the test. i converted the panics into prints so at least we can see when there are unknown features
fixes missing feature id 0xfc12b1cef363afa7 in conformance
yewman
previously approved these changes
Mar 23, 2026
yewman
previously approved these changes
Mar 25, 2026
Fixes 894 transaction fixtures, breaks 10 others.
yewman
reviewed
Mar 26, 2026
There was a work-around for this already, but apparently it was insufficient. Also moves the assertion below the index into the `dedupe_map`, so that if this was to go OOB again somehow, the panic includes the actual index and the length it went over.
Previous fix did fix behaviour in the tested build modes, but could still potentially result in a similar or the same kind of bug given different optimization heuristics. This solves the problem definitively by avoiding potential invalidation of the `prev` pointer entirely.
… account load errors
yewman
previously approved these changes
Mar 30, 2026
yewman
approved these changes
Mar 30, 2026
InKryption
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades Sig's conformance harnesses, CI pipeline, and feature set to be compatible with Agave 4.0.
The diff is large, but the changes to existing sig code are small.
parseoutthat I added to parse test outputs. See the readme for more information.Current Test Results
All of the remaining failures are related to crypto programs. #1296 fixes the 80 zksdk instruction harness tests. The 102 txn harness failures are all related to the zk el gamal proof and secp256r1 programs, and we do not have fixes for those yet.
Overview
v1.pb.zig) and hand-wrote FlatBuffer serialization (elf_types.zig) to match Agave 4.0's protosol definitions.txn_execute.zig,elf_loader.zig,utils.zig, andvm_interp.zigto consume/produce the new formats.Caveats
10for txn,0for instr/VM) rather than read from the fixture. This was previously the fallback behavior only when the slot is unspecified. Now the slot is never specified, so it's the only behavior.failing.txtrepresent existing conformance gaps that predate this PR. Fixing these is not in scope.