Skip to content

RFC: Add translations for exception reasons #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrushlow merged 5 commits into from
Jan 31, 2022
Merged

RFC: Add translations for exception reasons #206

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b8c934
Add translations for exception messages
bocharsky-bw Jan 28, 2022
acb021d
Add a few more translation messages from Maker
bocharsky-bw Jan 28, 2022
c869e6d
Add error messages hardcoded in Maker as constants
bocharsky-bw Jan 28, 2022
519e97d
Fix exception reason message
bocharsky-bw Jan 28, 2022
8078b24
Merge branch 'main' of github.com:SymfonyCasts/reset-password-bundle …
bocharsky-bw Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception/FakeRepositoryException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ final class FakeRepositoryException extends \Exception implements ResetPasswordE
{
public function getReason(): string
{
return 'Please update the request_password_repository configuration in config/packages/reset_password.yaml to point to your "request password repository` service.';
return 'Please update the request_password_repository configuration in config/packages/reset_password.yaml to point to your "request password repository" service.';
}
}
3 changes: 3 additions & 0 deletions src/Exception/ResetPasswordExceptionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,8 @@
*/
interface ResetPasswordExceptionInterface extends \Throwable
{
public const MESSAGE_PROBLEM_VALIDATE = 'There was a problem validating your password reset request';
public const MESSAGE_PROBLEM_HANDLE = 'There was a problem handling your password reset request';
Copy link
Member Author

@bocharsky-bw bocharsky-bw Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those strings are hardcode in Maker - probably we could migrate them in this bundle as well and then just reuse these constants in Maker, see https://github.com/symfony/maker-bundle/blob/085358c107a7047b4889455d7518d0dbf55169f1/src/Resources/skeleton/resetPassword/ResetPasswordController.tpl.php#L160


public function getReason(): string;
}
24 changes: 24 additions & 0 deletions src/Resources/translations/ResetPasswordBundle.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,30 @@
<source>%count% minute|%count% minutes</source>
<target>%count% minute|%count% minutes</target>
</trans-unit>
<trans-unit id="6">
<source>There was a problem validating your password reset request</source>
<target>There was a problem validating your password reset request</target>
</trans-unit>
<trans-unit id="7">
<source>There was a problem handling your password reset request</source>
<target>There was a problem handling your password reset request</target>
</trans-unit>
<trans-unit id="8">
<source>The link in your email is expired. Please try to reset your password again.</source>
<target>The link in your email is expired. Please try to reset your password again.</target>
</trans-unit>
<trans-unit id="9">
<source>Please update the request_password_repository configuration in config/packages/reset_password.yaml to point to your "request password repository" service.</source>
<target>Please update the request_password_repository configuration in config/packages/reset_password.yaml to point to your "request password repository" service.</target>
</trans-unit>
<trans-unit id="10">
<source>The reset password link is invalid. Please try to reset your password again.</source>
<target>The reset password link is invalid. Please try to reset your password again.</target>
</trans-unit>
<trans-unit id="11">
<source>You have already requested a reset password email. Please check your email or try again soon.</source>
<target>You have already requested a reset password email. Please check your email or try again soon.</target>
</trans-unit>
</body>
</file>
</xliff>