[Bug] On Windows this action leaves the wrong link.exe first in the `PATH`.

[dabrahams]

As noted here. Setting up Swift 5.10 appears to finish on Windows, but it leaves Path set such that when swiftc is used to link, it finds /usr/bin/link.exe (from MINGW I think) rather than the link.exe that comes from the MS tools (workflow run):

Run cmake --build Swifty-LLVM/.cmake-build
  cmake --build Swifty-LLVM/.cmake-build
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    swift-version: 5.10
    url_prefix: https://github.com/hylo-lang/llvm-build/releases/download/[2](https://github.com/hylo-lang/Swifty-LLVM/actions/runs/8840879423/job/24276998977#step:10:2)0240303-215025
    llvm_package_basename: llvm-17.0.6-x86_64-unknown-windows-msvc17-Debug
    SDKROOT: C:\Users\runneradmin\AppData\Local\Programs\Swift\Platforms\5.10.0\Windows.platform\Developer\SDKs\Windows.sdk\
[0/2] Re-checking globbed directories...
[1/55] Linking Swift static library lib\ArgumentParserToolInfo.lib
FAILED: lib/ArgumentParserToolInfo.lib _deps/swiftargumentparser-build/Sources/ArgumentParserToolInfo/CMakeFiles/ArgumentParserToolInfo.dir/ToolInfo.swift.obj swift/ArgumentParserToolInfo.swiftmodule 
C:\Windows\system[3](https://github.com/hylo-lang/Swifty-LLVM/actions/runs/8840879423/job/24276998977#step:10:3)2\cmd.exe /C "cd . && C:\Users\runneradmin\AppData\Local\Programs\Swift\Toolchains\5.10.0+Asserts\usr\bin\swiftc.exe -j [4](https://github.com/hylo-lang/Swifty-LLVM/actions/runs/8840879423/job/24276998977#step:10:4) -num-threads 4 -emit-library -static -o lib\ArgumentParserToolInfo.lib -module-name ArgumentParserToolInfo -module-link-name ArgumentParserToolInfo -emit-module -emit-module-path swift\ArgumentParserToolInfo.swiftmodule -emit-dependencies  -Onone -g -incremental -libc MDd -output-file-map _deps\swiftargumentparser-build\Sources\ArgumentParserToolInfo\CMakeFiles\ArgumentParserToolInfo.dir\Debug\output-file-map.json  D:\a\Swifty-LLVM\Swifty-LLVM\Swifty-LLVM\.cmake-build\_deps\swiftargumentparser-src\Sources\ArgumentParserToolInfo\ToolInfo.swift    && cd ."
error: link command failed with exit code 1 (use -v to see invocation)

/usr/bin/link: extra operand '/OUT:lib\\ArgumentParserToolInfo.lib'

Try '/usr/bin/link --help' for more information.

[soumyamahunt]

@dabrahams fix has been released: https://github.com/SwiftyLab/setup-swift/releases/tag/v1.8.0

[soumyamahunt]

@dabrahams in next release of the action I am keeping the VS linker option as a new input prefer-visual-studio-linker:

setup-swift/action.yml

Lines 57 to 62 in 05fec64

	prefer-visual-studio-linker:
	description: >-
	Whether to prefer using the Visual Studio linker over the default linker. This is unsafe and not recommended to set.
	If you are getting any linker errors with this option, try setting `update-sdk-modules` to `true`.
	required: false
	default: 'false'

By default, the Visual Studio linker won't be used. This is because I am seeing significant performance improvement if Visual Studio linker setup is removed. After this change performance is similar to the action mentioned in #233 and there is no adverse impact I am seeing in swift build/test.

I will do the next release once the next Swift version is released.