Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper functions for scrolling to the edges or by page of a scroll view #888

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Helper functions for scrolling to the edges or by page of a scroll view #888

merged 7 commits into from
Aug 20, 2020

Conversation

guykogus
Copy link
Contributor

🚀

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 5.0.
  • New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.

@guykogus guykogus requested a review from LucianoPAlmeida July 27, 2020 10:42
@codecov
Copy link

codecov bot commented Jul 27, 2020 •
edited
Loading

Codecov Report

Merging #888 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   92.92%   93.02%   +0.09%     
==========================================
  Files         100      100              
  Lines        3448     3497      +49     
==========================================
+ Hits         3204     3253      +49     
  Misses        244      244
Flag Coverage Δ
#ios 95.73% <100.00%> (+0.06%) ⬆️
#macos 82.94% <ø> (ø)
#tvos 95.79% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/SwifterSwift/UIKit/UITableViewExtensions.swift 95.16% <ø> (-0.37%) ⬇️
...es/SwifterSwift/UIKit/UIScrollViewExtensions.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46997c6...0e8c694. Read the comment docs.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Jul 27, 2020 •
edited
Loading

4 Messages
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖 iOS: Executed 699 tests, with 0 failures (0 unexpected) in 19.874 (21.599) seconds
📖 tvOS: Executed 662 tests, with 0 failures (0 unexpected) in 4.005 (4.539) seconds
📖 macOS: Executed 514 tests, with 0 failures (0 unexpected) in 7.044 (7.469) seconds

Generated by 🚫 Danger

@LucianoPAlmeida LucianoPAlmeida self-requested a review August 14, 2020 12:28
LucianoPAlmeida
LucianoPAlmeida previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@LucianoPAlmeida LucianoPAlmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guykogus guykogus requested a review from gurgeous August 19, 2020 15:14
gurgeous
gurgeous approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@gurgeous gurgeous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and nice work on the tests

@LucianoPAlmeida LucianoPAlmeida merged commit a9a2532 into master Aug 20, 2020
nasircsms pushed a commit to nasircsms/SwifterSwift that referenced this pull request Aug 26, 2020
Merge branch 'master' of https://github.com/SwifterSwift/SwifterSwift
a2d5f44 
* 'master' of https://github.com/SwifterSwift/SwifterSwift: (79 commits)
  Helper functions for scrolling to the edges or by page of a scroll view (SwifterSwift#888)
  Add XCTest extension for comparing Color objects (SwifterSwift#889)
  Fix swiftlint error (SwifterSwift#894)
  Bump kramdown from 2.1.0 to 2.3.0 (SwifterSwift#891)
  Added note for UIView.addShadow() (SwifterSwift#890)
  loadFromNib(withClass) (SwifterSwift#885)
  constraint finders (widthConstraint, heightConstraint, leadingConstraint, trailingConstraint, topConstraint, bottomConstraint) (SwifterSwift#886)
  added String.regexEscaped (SwifterSwift#883)
  Make √ generic for FloatingPoint values (SwifterSwift#880)
  Update UITextField extensions (SwifterSwift#878)
  Added `masksToBounds` (IBInspectable) extension (SwifterSwift#877)
  Reinstate debounce function (SwifterSwift#869)
  `RandomAccessCollection`/`Collection` generalisations (SwifterSwift#863)
  Added HKActivitySummary extensions (SwifterSwift#875)
  Added new method for easily instantiating a view controller from a storyboard (SwifterSwift#860)
  Clean up code (SwifterSwift#864)
  fixed "".truncated crashed (SwifterSwift#866)
  Deprecated map(by:), compactMap(by:), filter(by:) (SwifterSwift#862)
  Overloaded 'contains' operator for string regex matching (SwifterSwift#858)
  Added convenient wrapper to asyncAfter (SwifterSwift#859)
  ...

# Conflicts:
#	Sources/SwifterSwift/AppKit/NSColorExtensions.swift
#	Sources/SwifterSwift/AppKit/NSImageExtensions.swift
#	Sources/SwifterSwift/AppKit/NSViewExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGColorExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGFloatExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGPointExtensions.swift
#	Sources/SwifterSwift/CoreGraphics/CGSizeExtensions.swift
#	Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift
#	Sources/SwifterSwift/SwiftStdlib/StringExtensions.swift
#	SwifterSwift.xcodeproj/project.pbxproj
#	Tests/AppKitTests/NSColorExtensionsTests.swift
#	Tests/SwiftStdlibTests/StringExtensionsTests.swift
@omaralbeik omaralbeik deleted the scroll-view branch May 9, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucianoPAlmeida LucianoPAlmeida LucianoPAlmeida approved these changes

@gurgeous gurgeous gurgeous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guykogus @SwifterSwiftBot @gurgeous @LucianoPAlmeida