-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove method that exists in stdlib #1221
Conversation
after removing method, Unit test testCountWhere still works. https://developer.apple.com/documentation/swift/sequence/count(where:)
Doesn't sound like breaking given stdlib has same method. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 68.22% 68.17% -0.05%
==========================================
Files 98 98
Lines 3647 3642 -5
==========================================
- Hits 2488 2483 -5
Misses 1159 1159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nitpick...
Checklist
@available
if not.