Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method that exists in stdlib #1221

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

vikingosegundo
Copy link
Contributor

@vikingosegundo vikingosegundo commented Nov 15, 2024

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • [ x] New extensions are written in Swift 5.6.
  • [ x] New extensions support iOS 12.0+ / tvOS 12.0+ / macOS 10.13+ / watchOS 4.0+, or use @available if not.
  • [ x] I have added tests for new extensions, and they passed.
  • [ x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • [ x] All extensions are declared as public.
  • [ x] I have added a changelog entry describing my changes.

@LucianoPAlmeida
Copy link
Member

Doesn't sound like breaking given stdlib has same method.
Can you please update changelog and we will be good to go :)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (19d8965) to head (e9dcbe3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   68.22%   68.17%   -0.05%     
==========================================
  Files          98       98              
  Lines        3647     3642       -5     
==========================================
- Hits         2488     2483       -5     
  Misses       1159     1159              
Flag Coverage Δ
macos 97.06% <ø> (-0.01%) ⬇️
tvos 58.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Nov 15, 2024

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

Copy link
Contributor

@guykogus guykogus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpick...

@guykogus guykogus merged commit 346daae into SwifterSwift:master Jan 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants