Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors & improvements #32

Merged
merged 2 commits into from
May 14, 2022
Merged

Refactors & improvements #32

merged 2 commits into from
May 14, 2022

Conversation

rrroyal
Copy link
Contributor

@rrroyal rrroyal commented May 14, 2022

  • Removed duplicated .svg assets
  • Optimised channel sorting&filtering
  • Moved loginBG to Assets catalog
  • Removed old Native Discord references in file headers
  • Renamed extensions with convention Type+
  • Added NSTextField extension with backgroundColor override (to allow customisation of TextEditor.background)
  • Refactored optionals unwrapping
  • Refactored navigation in SettingsView with enums (instead of raw strings)
  • Refactored TagCloudView to get rid of AnyView
  • Other minor improvements & optimizations

@cryptoAlgorithm
Copy link
Member

Thanks so much! This PR seems like a big one, and its really appreciated!

@cryptoAlgorithm cryptoAlgorithm merged commit 44bc18b into SwiftcordApp:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrroyal @cryptoAlgorithm