-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Weird localization words order in onboarding title screen. #158
Fix: Weird localization words order in onboarding title screen. #158
Conversation
… (Norwegian Bokmål (Norway))
… (Chinese, Simplified)
… (Chinese, Traditional)
By the way, I'd confirmed translations correctness of this fix with ChatGPT and DeepL. |
Haha that's hilarious! 😂 These look good, but I'll need to take some time to ensure merging these don't completely screw up contributions from Weblate (which are already messed up as is). Sorry for the delay, and thanks for your efforts for bringing swiftcord to more languages! |
Thanks for confirming this pull request! I see. It's good timing because I've wanted to refactor styling logic of So I work it until these correct translation is coming. |
I worked the refactor for styling I'd used the emphasize clause to style string but we shouldn't do that. This fix has benefits below.
|
About this Pull Request
This pull request fixed a problem that onboarding title words order was wrong on Japanese.
What was the problem?
The Japanese localization of "onboarding.title" should be "Swiftcord へようこそ" but because of a localization interpolation code was wrong, so it had been shown "へようこそ Swiftcord".
To convey that the word order in "へようこそ Swiftcord" is grammatically incorrect in Japanese, you can use the following translation in English like this:
Translation: Swiftcord to welcome .
I hope you realize such weird words order.
Screenshots (Before and After)
This section also stands for proving there are no regressions.
References
https://www.kodeco.com/29501177-attributedstring-tutorial-for-swift-getting-started
https://gist.github.com/mattyoung/5be253f8dc7ac924f23362472c5e3344