Remove Starscream Dependency + Rewrite WebSocket Wrapper #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic Gateway handling works, but without any reconnection logic
stable Please open an issue if you encounter any bugs, and include logs as well
|
This branch will be merged soon (by the end of next week) if no reports of connection issues emerge. Currently, only code cleanup and old code removal is pending. |
…ment in delegate) Add delay before reconnecting when the session cannot be resumed
|
With this comment, all Starscream-related WebSocket wrapper code has been removed. This branch can now be merged, if there are no more reliability issues. |
Converted RobustWebSocket and Gateway to use OSLog for logging
|
This will be merged by the end of the day as all tasks have been completed, and no more reliability issues have been found. |
|
And with that commit, this branch will finally be merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to remove the Starscream dependency for WebSocket connections, and uses URLSessionWebSocketTask instead.
The WebSocket wrapper has also been completely rewritten for higher reliability in reconnections!
These improvements should fix most connection bugs as well as resolve performance issues related to the socket.