Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Text doesn't wrap when composing a message #133

Closed
danieltaylor opened this issue Jan 17, 2023 · 3 comments · Fixed by #134
Closed

[Bug]: Text doesn't wrap when composing a message #133

danieltaylor opened this issue Jan 17, 2023 · 3 comments · Fixed by #134
Labels
bug Something isn't working ui User interface-related issues

Comments

@danieltaylor
Copy link

danieltaylor commented Jan 17, 2023

Describe the Bug

Bug Description
When composing a message, text does not wrap to a new line if the text goes over the length of the input box.

This issue was previously reported in #45. It was marked as resolved, but seems to have returned in the latest release.

Actual Behaviour
Text is cut off. It is actually there but is not visible. When the message is sent, everything that was typed shows up as expected.
Screen Shot 2023-01-16 at 5 31 10 PM

Expected Behavior
Swiftcord should behave similarly to the Discord app:
Screen Shot 2023-01-16 at 5 32 51 PM

Reproducing the Bug

  1. Type a somewhat long message.

Version

0.5.1

Category

Message rendering

@danieltaylor danieltaylor added bug Something isn't working triage Waiting for this issue to be triaged labels Jan 17, 2023
@cryptoAlgorithm
Copy link
Member

Hi @danieltaylor, may I know what macOS version you're using? This appears to be a bug on macOS 12, and I can't really fix that as its a problem within apple's SwiftUI implementation in the system itself.

@cryptoAlgorithm cryptoAlgorithm added ui User interface-related issues and removed triage Waiting for this issue to be triaged labels Jan 27, 2023
@bnwa
Copy link

bnwa commented Jan 31, 2023

Definitely running into this myself on 12.6.3

@cryptoAlgorithm
Copy link
Member

Fixed by #134, thanks to @ErrorErrorError!

Screen.Recording.2023-02-15.at.5.00.02.PM.mov

cryptoAlgorithm added a commit that referenced this issue Feb 15, 2023
)

* patch (translations): merge latest localisations from weblate

* fix: use non-canary login endpoint

the canary login endpoint appears to be crashing currently

* fix (discordkit): pin dep to commit before breaking changes

breaking changes were made for the i-am-speed branch, which caused builds to fail for main

* patch (README): update badge URL and sponsors

* fix(MessageInputView): text now expands based on character length

Improves button layout on text expansion and added pointer cursor on buttons.

Fixes #133

* Merge i-am-speed into main

update PR branch with latest commits on base branch

commit fa39f14
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 14:54:23 2023 +0800

    patch (lottie): update Lottie usages to match new naming

commit cc83d41
Author: CryptoAlgo <[email protected]>
Date:   Wed Feb 15 14:47:03 2023 +0800

    chore (actions): Ci improvements (#138)

    * chore (actions): significant action cleanups

    * bump (actions): update actions deps to latest vers

    patch (actions): improve yaml style

    fix (actions): set ddata cache key correctly

    * patch (actions): standardise workflow naming

commit 75dcff4
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 11:37:48 2023 +0800

    patch: re-add team ID

    patch (action): get rid of xcpretty temporarily for debugging

commit cc5e56b
Author: CryptoAlgo <[email protected]>
Date:   Wed Feb 15 11:26:58 2023 +0800

    bump (actions): use Xcode 14.2

commit 01d9629
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 10:56:17 2023 +0800

    patch (actions): make build action run on every commit

commit 5b877d5
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 10:54:52 2023 +0800

    fix (actions): set correct sentry org to fix action builds

* fix (messageInput): size bottom padding according to size of text field

---------

Co-authored-by: vinkwok <[email protected]>
Co-authored-by: CryptoAlgo <[email protected]>
cryptoAlgorithm added a commit that referenced this issue Feb 26, 2023
)

* patch (translations): merge latest localisations from weblate

* fix: use non-canary login endpoint

the canary login endpoint appears to be crashing currently

* fix (discordkit): pin dep to commit before breaking changes

breaking changes were made for the i-am-speed branch, which caused builds to fail for main

* patch (README): update badge URL and sponsors

* fix(MessageInputView): text now expands based on character length

Improves button layout on text expansion and added pointer cursor on buttons.

Fixes #133

* Merge i-am-speed into main

update PR branch with latest commits on base branch

commit fa39f14
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 14:54:23 2023 +0800

    patch (lottie): update Lottie usages to match new naming

commit cc83d41
Author: CryptoAlgo <[email protected]>
Date:   Wed Feb 15 14:47:03 2023 +0800

    chore (actions): Ci improvements (#138)

    * chore (actions): significant action cleanups

    * bump (actions): update actions deps to latest vers

    patch (actions): improve yaml style

    fix (actions): set ddata cache key correctly

    * patch (actions): standardise workflow naming

commit 75dcff4
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 11:37:48 2023 +0800

    patch: re-add team ID

    patch (action): get rid of xcpretty temporarily for debugging

commit cc5e56b
Author: CryptoAlgo <[email protected]>
Date:   Wed Feb 15 11:26:58 2023 +0800

    bump (actions): use Xcode 14.2

commit 01d9629
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 10:56:17 2023 +0800

    patch (actions): make build action run on every commit

commit 5b877d5
Author: vinkwok <[email protected]>
Date:   Wed Feb 15 10:54:52 2023 +0800

    fix (actions): set correct sentry org to fix action builds

* fix (messageInput): size bottom padding according to size of text field

---------

Co-authored-by: vinkwok <[email protected]>
Co-authored-by: CryptoAlgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui User interface-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants