Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

XCAssets: added explicit type to allValues array #69

Closed

Conversation

NachoSoto
Copy link

After updating to SwiftGen 5.0, one of my targets started complaining about this:
screen shot 2017-08-15 at 3 37 13 pm

@djbe
Copy link
Member

djbe commented Aug 15, 2017

Hi @NachoSoto,

Thank you for the fix. Unfortunately, your changes are superseded by the named colors PR:
#68

There we added type information to the all values arrays. If you could review it to see if it fits your needs?

@NachoSoto
Copy link
Author

Yup 👍 You can close this then.

@AliSoftware
Copy link
Collaborator

Just to confirm, besides that error, the empty Asset enum (and allValues) were expected given your context? (e.g. you actually do have an empty asset catalog, explaining why swiftgen generated empty enums)? Or is there an additional issue hidden there?

@NachoSoto NachoSoto deleted the xcassets-all-values-type branch August 15, 2017 22:59
@NachoSoto
Copy link
Author

Just to confirm, besides that error, the empty Asset enum (and allValues) were expected given your context? (e.g. you actually do have an empty asset catalog, explaining why swiftgen generated empty enums)? Or is there an additional issue hidden there?

That's correct, there's no other issue here. The asset catalog is technically not empty, but it only contains the AppIcon, which makes sense that it's not included in the generated file.

@AliSoftware
Copy link
Collaborator

Thanks for the confirmation 👍

@djbe djbe modified the milestone: 2.1.0 Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants