Added clr files parser #81
Conversation
| public func parseFile(path: String) { | ||
| if let colorsList = NSColorList(name: "UserColors", fromFile: path) { | ||
| for keyColorPair in colorsList.allKeys.map({ ($0, colorsList.colorWithKey($0)) }) { | ||
| let colorName = keyColorPair.0.stringByReplacingOccurrencesOfString(" ", withString: "") |
There was a problem hiding this comment.
Why is the removal of spaces necessary here?
There was a problem hiding this comment.
In palettes who knows what users can have. At least we provide some sanity checks. Of course if user have Color#1 like names it will not work anyway.
There was a problem hiding this comment.
But you don't need that. It's not the work of the parser to sanitize the color name. It's the work of the template filters, like here.
That's because people could want to customize their template and use the real name (with spaces and all) for purposes other than just use them as the swift identifier, but to use them to generate comments for each color, or to associate a color name as a String or implement a nice CustomStringConvertible or whatnot. But if they use it as a swift identifier, that's their responsibility to call the swiftIdentifier Stencil filter on the name in their template in the appropriate place(s).
|
Aside from the 1-2 comments I did on your last commit, looks good to merge, nice work 👍 |
Added `.clr` (color palettes) parser
This PR adds support for clr files using the same templates used for text files.