Disabled function_parameter_count rule SwiftLint #428
Conversation
CHANGELOG.md
Outdated
| @@ -56,6 +56,9 @@ | |||
| [David Jennes](https://github.com/djbe) | |||
| [#417](https://github.com/SwiftGen/SwiftGen/pull/417) | |||
| [#422](https://github.com/SwiftGen/SwiftGen/pull/422) | |||
| * Disabled a SwiftLint rule for function parameter count. | |||
CHANGELOG.md
Outdated
| @@ -56,6 +56,9 @@ | |||
| [David Jennes](https://github.com/djbe) | |||
| [#417](https://github.com/SwiftGen/SwiftGen/pull/417) | |||
| [#422](https://github.com/SwiftGen/SwiftGen/pull/422) | |||
| * Disabled a SwiftLint rule for function parameter count. | |||
| [Oleg Gorbatchev](https://github.com/gorbat-o) | |||
| [#427](https://github.com/SwiftGen/SwiftGen/pull/417) | |||
There was a problem hiding this comment.
Issue number and url are incorrect (we usually point to the PR, #428 in this case).
| @@ -6,6 +6,7 @@ import Foundation | |||
|
|
|||
| // swiftlint:disable superfluous_disable_command | |||
| // swiftlint:disable file_length | |||
| // swiftlint:disable function_parameter_count | |||
There was a problem hiding this comment.
I'd add this a bit lower, on line 41, with the other disables around the enum. I'd also re-enable it again after the enum. (same feedback for the other templates)
| @@ -39,11 +38,13 @@ import Foundation | |||
| {% set enumName %}{{param.enumName|default:"L10n"}}{% endset %} | |||
| {{accessModifier}} enum {{enumName}} { | |||
| {% if tables.count > 1 %} | |||
| // swiftlint:disable function_parameter_count | |||
There was a problem hiding this comment.
Maybe I misunderstood what @djbe meant by suggesting you to move those next to the enum, but wouldn't it be more consistent to put that rule with the others just 4 lines above? i.e. add them to the list of already 3 disabled rules there?
// swiftlint:disable identifier_name line_length type_body_length function_parameter_count
_(of course same for when you re-enable the rule, I'd personally re-enable it in line 52 with the other rules)
I'm probably just nitpicking, but I personally feel easier to maintain having all swiftlint disabled rules grouped next to them when possible/appropriate 😉
There was a problem hiding this comment.
Uh yeah, that's what I meant, apologies if that was unclear (I only quickly glanced at the line numbers).
There was a problem hiding this comment.
I totally agree, I thought about that too,
But I strictly followed the demand 😅
djbe
force-pushed
the
fix/swiftlint-warning
branch
from
c4f5d8e
to
377429f
Compare
djbe
force-pushed
the
fix/swiftlint-warning
branch
from
377429f
to
b7f89b7
Compare
CHANGELOG.mdfile to explain my changes and credit myselfThis closes #427
Some keys generated by SwiftGen can have more then 5 parameters, it makes SwiftLint unhappy :'(