Swift 5 #119
Swift 5 #119
Conversation
djbe
force-pushed
the
feature/swift-5
branch
2 times, most recently
from
4f39ad7
to
1497041
Compare
| @@ -1 +1 @@ | |||
| 2.3.7 | |||
| 2.4.5 | |||
There was a problem hiding this comment.
If there's no need for newest additions in latest Ruby versions we should try to keep the Ruby version shipped with latest version of macOS (don't even know which it is and if 2.3.7 was already that) so that people not wanting to use rvm/rbenv won't have to worry. Except if you saw features in more recent Ruby versions that we needed?
There was a problem hiding this comment.
I actually tried that in this PR (and the other PR in SwiftGen), but it starts complaining about an unknown version of ruby, so 🤷♂️
|
I'm curious as to why linux swift 4.0 can't find Stencil... It has a |
| shell: /bin/bash --login -eo pipefail | ||
| - &linux-config | ||
| environment: | ||
| CIRCLE_ARTIFACTS: /tmp/circleci-artifacts | ||
| CIRCLE_TEST_REPORTS: /tmp/circleci-test-results | ||
| BUNDLE_PATH: vendor/bundle | ||
| docker: | ||
| - image: norionomura/jazzy:swift-4.2.0 |
There was a problem hiding this comment.
We don't have a docker image with Swift 5 support yet.
Those Docker images with Swift 5 are now since available: https://github.com/norio-nomura/docker-jazzy
|
This PR is superseded by #127, which (amongst other things) upgrades to Swift 5. |
Few things:
lowerFirstWordcrashes in swift 5 becausescalars.index(after: start)crashes for an empty string. I've added a check forisEmptybefore it, or we could invert the "after start" and "before end" checks. TBH, I think theisEmptycheck is clearer in its intent.