Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Expose deeplinks. #275

Merged
merged 2 commits into from
May 18, 2021
Merged

Expose deeplinks. #275

merged 2 commits into from
May 18, 2021

Conversation

Lukas-Stuehrk
Copy link
Member

This change adds links to the name of all members, so it's easy to copy the direct link. This implements #110.

I chose a different approach than adding a chain symbol when hovering the name. The entire name is a link. This leads to some visual changes in the generated documentation. I can change this behavior to the behavior described in the original issue if wanted.

Before the changes:
Screenshot 2021-05-08 at 00 12 21

After the changes when the entire name becomes the link to the anchor:
Screenshot 2021-05-08 at 00 12 59

@mattt mattt marked this pull request as draft May 18, 2021 16:27
@mattt
Copy link
Contributor

mattt commented May 18, 2021

This is a nice change, @Lukas-Stuehrk!

Before we merge this in, I'd like to give this a quick once-over to get the design a bit closer to what I had in mind with #110 (comment).

@mattt mattt marked this pull request as ready for review May 18, 2021 16:34
Copy link
Contributor

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, scratch that — this looks fantastic as-is 🤩

For whatever reason, the screenshots initially looked off to me. But seeing them in a live render, I wouldn't change a thing. Great work, @Lukas-Stuehrk!

Adding a changelog entry now and merging after that.

@mattt mattt merged commit cc45688 into SwiftDocOrg:master May 18, 2021
@Lukas-Stuehrk
Copy link
Member Author

Thanks! 🙇

Initially, I wanted to build the version as described in #110 and had the current solution as intermediate step. But then I liked the visuals so much that I decided to keep it and go with this solution. I think it looks great and matches the visual language of the index page.

@Lukas-Stuehrk Lukas-Stuehrk deleted the add-deeplinks branch May 18, 2021 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants