[copyicu] Copy dir to swift/../icu #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After building libicu, the directory needs to the copied to the location expected by the build script; see: https://github.com/apple/swift/compare/master...SwiftAndroid:20dbe893a8f2fb77bf8fc7f067c602d273181362?expand=1#diff-820a1d13441195f42bb1712046b14552R29 Add this step to the `copyicu.sh` script, to make it a little easier for contributors to pick up on.
zhuowei
added a commit
that referenced
this pull request
Jan 11, 2016
[copyicu] Copy dir to swift/../icu
Member
Author
|
Thanks, @zhuowei! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building libicu, the directory needs to the copied to the
location expected by the build script; see:
https://github.com/apple/swift/compare/master...SwiftAndroid:20dbe893a8f2fb77bf8fc7f067c602d273181362?expand=1#diff-820a1d13441195f42bb1712046b14552R29
Add this step to the
copyicu.shscript, to make it a littleeasier for contributors to pick up on.