chore: Update dns delegation role

SvenKirschbaum · Mar 9, 2024 · 8b4f80d · 8b4f80d
1 parent d8320ea
commit 8b4f80d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/lib/SharePipelineStack.ts b/lib/SharePipelineStack.ts
@@ -15,9 +15,9 @@ export default class SharePipelineStack extends Stack {
     pipeline.addStage(new ShareStage(this, 'Staging', {
       domain: 'share-staging.kirschbaum.cloud',
       delegation: {
-        parentDomain: 'kirschbaum.cloud',
-        accountId: '212836051001',
-        roleName: 'CloudshareDNSDelegationRole',
+        parentZoneId: 'Z0202936UCVSS5ELQXV6',
+        accountId: '058264224454',
+        roleName: 'CloudshareStagingDnsDelegationRole',
       },
       keycloak: {
         url: 'https://id.elite12.de',
@@ -36,9 +36,9 @@ export default class SharePipelineStack extends Stack {
       new ShareStage(scope, 'Prod', {
         domain: 'share.kirschbaum.cloud',
         delegation: {
-          parentDomain: 'kirschbaum.cloud',
-          accountId: '212836051001',
-          roleName: 'CloudshareDNSDelegationRole',
+          parentZoneId: 'Z0202936UCVSS5ELQXV6',
+          accountId: '058264224454',
+          roleName: 'CloudshareProdDnsDelegationRole',
         },
         keycloak: {
           url: 'https://id.elite12.de',

diff --git a/lib/ShareUtilStack.ts b/lib/ShareUtilStack.ts
@@ -50,6 +50,7 @@ export default class ShareUtilStack extends Stack {
         new route53.CrossAccountZoneDelegationRecord(this, 'DelegationRecord', {
           delegatedZone: this.zone,
           parentHostedZoneName: delegationOptions.parentDomain,
+          parentHostedZoneId: delegationOptions.parentZoneId,
           delegationRole: iam.Role.fromRoleArn(this, 'DelegationRole', Stack.of(this).formatArn({
             region: '', // IAM is global in each partition
             service: 'iam',

diff --git a/lib/interfaces/DelegationOptions.ts b/lib/interfaces/DelegationOptions.ts
@@ -2,7 +2,11 @@ export interface DelegationOptions {
     /**
      * The name of the parent zone (domain)
      */
-    parentDomain: string,
+    parentDomain?: string,
+    /**
+     * The id of the parent zone
+     */
+    parentZoneId?: string,
     /**
      * The id of the account containing the parent zone
      */