STYLE: Replace _ELASTIX_BUILD_LIBRARY by BaseComponent::IsElastixLibrary #231
Conversation
Replaced `_ELASTIX_BUILD_LIBRARY` preprocessor definition by static member function, `BaseComponent::IsElastixLibrary()`. Anticipates sharing the intermediate binary object files between the Elastix executable and the Elastix library, possibly building them within the same project, or the same (Visual Studio) solution.
N-Dekker
force-pushed
the
Remove-_ELASTIX_BUILD_LIBRARY
branch
from
8c72767 to
64ced59
Compare
|
@mstaring @stefanklein Please check carefully! 😃 I think we need to remove the dependencies on |
|
@stefanklein As you suggested this morning @ LUMC, I compared the output directory of the example from "elastix\dox", as generated by the official elastix 5.0.0 release to the output directory generated from this pull request. I think they look quite comparable 😄 I ran:
result.0.mhd, result.0.raw, result.1.mhd, result.1.raw, and TransformParameters.0.txt are exactly the same in both output directories. elastix.log has the same number of lines. I only observed different current date and time, and slightly different durations. |
|
Glancing through it, it looks good and I see no reason to worry :-) As indeed before and after looks the same, I trust the PR and you can merge |
Kasper Marstal reported yesterday via direct messaging that the introduction of `IsElastixLibrary()`, pull request #231, commit 64ced59 (March 2, 2020, "Replace _ELASTIX_BUILD_LIBRARY by BaseComponent::IsElastixLibrary"), did break SimpleElastix. SimpleElastix depends on the library interface, while it does not construct an `elastix::ELASTIX` library object. The most elegant and reliable fix appears to be flipping the default value returned by `IsElastixLibrary()`, from `false` to `true`, and then ensuring that the value is set to `false` at the start of each run of the executable.
Kasper Marstal reported yesterday via direct messaging that the introduction of `IsElastixLibrary()`, pull request #231, commit 64ced59 (March 2, 2020, "Replace _ELASTIX_BUILD_LIBRARY by BaseComponent::IsElastixLibrary"), did break SimpleElastix. SimpleElastix depends on the library interface, while it does not construct an `elastix::ELASTIX` library object. The most elegant and reliable fix appears to be flipping the default value returned by `IsElastixLibrary()`, from `false` to `true`, and then ensuring that the value is set to `false` at the start of each run of the executable. This applies to the transformix executable as well.
Replaced
_ELASTIX_BUILD_LIBRARYpreprocessor definition by static member function,BaseComponent::IsElastixLibrary().Anticipates sharing the intermediate binary object files between the Elastix executable and the Elastix library, possibly building them within the same project, or the same (Visual Studio) solution.