Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel iteration #354

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Parallel iteration #354

merged 1 commit into from
Feb 22, 2024

Conversation

rickwebiii
Copy link
Contributor

Parallel BSK generation

Copy link
Contributor

@samtay samtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just want to call out that you have now changed all the dst_iters to have parallel capabilities, which is probably fine, but if this is only relevant for a few cases, you could define a different variant of the dst_iter! macro too. E.g.

macro_rules! dst_iter {
    ($t:ty, $t_mut:ty, $wrapper_type: ty, $item_ref:ty, ($($t_bounds:ty,)*)) => {
        // existing stuff
    }
    ($t:ty, $t_mut:ty, $par_t:ty, $par_t_mut:ty, $wrapper_type: ty, $item_ref:ty, ($($t_bounds:ty,)*)) => {
        dst_iter! { $t, $t_mut, $wrapper_type, $item_ref, ($($t_bounds,)*) }
        // new parallel stuff
    }

@rickwebiii rickwebiii merged commit 3c4e08b into main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants