-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose symmetric encryptions #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanorendorff
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The cleanup of the components and splitting into the AsymmetricComponents and SymmetricComponents is a nice abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the outside, all this does is expose extra
encrypt_symmetric_*
methods wherever there wereencrypt_*
methods, on both theRuntime
and theLogProofBuilder
. Internally I've changed a few thingsruntime::BfvEncryptionComponents
. This lived at the runtime level and contained the higher level plaintext and ciphertext types that are supposed to be agnostic to seal, however it also contained types specific to seal. And it kind of forced a wrapping and unwrapping of seal data, when logproof itself is already seal specific. So instead, just define and deal with typesAsymmetricComponents
andSymmetricComponents
from the seal_fhe layer. The builder interacts with these as the runtime iterates over the inner plaintexts.seal_fhe::Encryptor
to track whether or not it supports sym/asym encryptions.See Sunscreen-tech/SEAL#8 for seal changes.