Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZKP tweaks #279

Merged
merged 31 commits into from
Jul 18, 2023
Merged

ZKP tweaks #279

merged 31 commits into from
Jul 18, 2023

Commits on Jul 11, 2023

  1. Export type alias for bulletproof backend fields 

    Also, keep bulletproof stuff namespaced to a `bulletproofs` module.
    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    69ef1cf View commit details
    Browse the repository at this point in the history

  2. Change sudoku to use pub over const

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bbce98a View commit details
    Browse the repository at this point in the history

  3. Docs updates

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a83f10e View commit details
    Browse the repository at this point in the history

  4. Rename / clean up sudoku

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b1101f3 View commit details
    Browse the repository at this point in the history

  5. Export Proof type 

    Basically required for being able to deserialize a proof
    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    fe6ad34 View commit details
    Browse the repository at this point in the history

  6. Add zkp/serde workspace example

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    00c15ca View commit details
    Browse the repository at this point in the history

  7. Drive by cleaning

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c72ea21 View commit details
    Browse the repository at this point in the history

  8. Exports necessary for gadget impls

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    13421e5 View commit details
    Browse the repository at this point in the history

  9. Rename compute_inputs to compute_hidden_inputs

    @samtay
    samtay committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f7c6028 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Add prove/verify builders

    @samtay
    samtay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8efa1ae View commit details
    Browse the repository at this point in the history

  2. Export the builder types 

    This isnt strictly necessary but it would be weird for these to not show up in the cargo docs
    @samtay
    samtay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0e5b36b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Clippy fix

    @samtay
    samtay committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f425b11 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Add helper .compile() & .runtime() methods to fhe prog fns 

    I do wonder if these should be defined in a separate trait, just so that they don't live next to the more internal functions in documentation.
    @samtay
    samtay committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    bee0e4d View commit details
    Browse the repository at this point in the history

  2. Use new swag to simplify the front-facing api docs example

    @samtay
    samtay committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f08e0e0 View commit details
    Browse the repository at this point in the history

  3. Add some whitespace

    @samtay
    samtay committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b1ba2df View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Switch to an extension trait

    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    9b67f60 View commit details
    Browse the repository at this point in the history

  2. Add an extension to ZkpProgramFn

    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    cd4df85 View commit details
    Browse the repository at this point in the history

  3. Take an owned ZkpBackend, rather than reference 

    Its typical to have the caller handle cloning, rather than taking a reference, requiring Clone impl, and forcing clone. Plus, as of now the only backend is a zero size null struct, so nothing to be gained by using a reference. It also just looks weird to always pass `&BulletproofsBackend::new()`
    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    29ebaa6 View commit details
    Browse the repository at this point in the history

  4. Update sudoku to use new swag

    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    d5474aa View commit details
    Browse the repository at this point in the history

  5. Target second attribute in multi attribute error

    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    5dc513c View commit details
    Browse the repository at this point in the history

  6. Enforce ordering zkp inputs: constants,public,private 

    Honestly this feels a little unnatural to me. Might want to reverse: private, public, constant and then change all the prove/verify methods to that ordering
    @samtay
    samtay committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    2fd8c90 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Build whitelist example in CI

    @samtay
    samtay committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    2d23542 View commit details
    Browse the repository at this point in the history

  2. Reorder constant->public->private to private->public->constant

    @samtay
    samtay committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    35e0902 View commit details
    Browse the repository at this point in the history

  3. Fix trailing ws

    @samtay
    samtay committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    1a0b724 View commit details
    Browse the repository at this point in the history

  4. Fix example

    @samtay
    samtay committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    c151f79 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Make .runtime() more consistent with .compile()

    @samtay
    samtay committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    37f7535 View commit details
    Browse the repository at this point in the history

  2. Get rid of some boilerplate impls

    @samtay
    samtay committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    874d909 View commit details
    Browse the repository at this point in the history

  3. Add custom zkp type example

    @samtay
    samtay committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3d8c12b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge remote-tracking branch 'origin/main' into samtay/zkp-tweaks

    @samtay
    samtay committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0871969 View commit details
    Browse the repository at this point in the history

  2. Move example run checks into example tests 

    Should speed up CI a bit
    @samtay
    samtay committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    50eb091 View commit details
    Browse the repository at this point in the history

  3. Change whitelist -> allowlist

    @samtay
    samtay committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    73c5f3b View commit details
    Browse the repository at this point in the history