Rename compute_inputs to compute_hidden_inputs

Sunscreen-tech · Jul 11, 2023 · f7c6028 · f7c6028
1 parent 13421e5
commit f7c6028
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/sunscreen/src/types/zkp/gadgets/arithmetic.rs b/sunscreen/src/types/zkp/gadgets/arithmetic.rs
@@ -82,7 +82,7 @@ impl Gadget for SignedModulus {
         2
     }
 
-    fn compute_inputs(
+    fn compute_hidden_inputs(
         &self,
         gadget_inputs: &[sunscreen_zkp_backend::BigInt],
     ) -> ZkpResult<Vec<sunscreen_zkp_backend::BigInt>> {
@@ -144,7 +144,7 @@ impl Inverse {
 }
 
 impl Gadget for Inverse {
-    fn compute_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
+    fn compute_hidden_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
         let x = gadget_inputs[0];
 
         if x == BigInt::ZERO {
@@ -193,14 +193,14 @@ mod tests {
     use super::*;
 
     #[test]
-    fn compute_inputs_is_correct() {
+    fn compute_hidden_inputs_is_correct() {
         let m = BigInt::from(22u32);
         let field_modulus = <BulletproofsBackend as ZkpBackend>::Field::FIELD_MODULUS;
 
         let gadget = SignedModulus::new(field_modulus, 16);
 
         let test_case = |x: BigInt| {
-            let outputs = gadget.compute_inputs(&[x, m]).unwrap();
+            let outputs = gadget.compute_hidden_inputs(&[x, m]).unwrap();
 
             let q = outputs[0];
             let r = outputs[1];

diff --git a/sunscreen/src/types/zkp/gadgets/binary.rs b/sunscreen/src/types/zkp/gadgets/binary.rs
@@ -26,7 +26,7 @@ impl ToUInt {
 }
 
 impl Gadget for ToUInt {
-    fn compute_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
+    fn compute_hidden_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
         let val = gadget_inputs[0];
 
         if self.n == 0 {
@@ -112,7 +112,7 @@ impl Gadget for ToUInt {
 pub struct AssertBinary;
 
 impl Gadget for AssertBinary {
-    fn compute_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
+    fn compute_hidden_inputs(&self, gadget_inputs: &[BigInt]) -> ZkpResult<Vec<BigInt>> {
         let val = gadget_inputs[0];
 
         if val != BigInt::ONE && val != BigInt::ZERO {

diff --git a/sunscreen_zkp_backend/src/jit.rs b/sunscreen_zkp_backend/src/jit.rs
@@ -348,7 +348,7 @@ where
                     .map(|x| node_outputs[x].clone().zkp_into())
                     .collect::<Vec<BigInt>>();
 
-                let hidden_inputs = g.compute_inputs(&args)?;
+                let hidden_inputs = g.compute_hidden_inputs(&args)?;
 
                 let mut next_nodes = query
                     .edges_directed(id, Direction::Outgoing)

diff --git a/sunscreen_zkp_backend/src/lib.rs b/sunscreen_zkp_backend/src/lib.rs
@@ -66,7 +66,7 @@ compile_error!("This crate currently requires a little endian target architectur
  *
  * We instead ask the prover to simply provide the binary decomposition
  * and prove that it's correct. To do this, we create a gadget. Its
- * [`compute_inputs`](Gadget::compute_inputs) method directly computes the
+ * [`compute_hidden_inputs`](Gadget::compute_hidden_inputs) method directly computes the
  * decomposition with shifting and masking. Then, the
  * [`gen_circuit`](Gadget::gen_circuit) method defined a circuit that proves
  * the following:
@@ -106,7 +106,7 @@ pub trait Gadget: Any + Send + Sync {
      *
      * Implementors should ensure this function runs in constant time.
      */
-    fn compute_inputs(&self, gadget_inputs: &[BigInt]) -> Result<Vec<BigInt>>;
+    fn compute_hidden_inputs(&self, gadget_inputs: &[BigInt]) -> Result<Vec<BigInt>>;
 
     /**
      * Returns the expected number of gadget inputs.