Polyarrays created from ciphertexts/public keys are converted out of NTT on creation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanorendorff
force-pushed
the
ntt-conversion
branch
from
a650181
to
6a36bd3
Compare
ryanorendorff
force-pushed
the
ntt-conversion
branch
from
6a36bd3
to
fe07477
Compare
ryanorendorff
commented
Aug 3, 2023
| Switches the polynomial array down one modulus by dropping the last modulus | ||
| in the set. | ||
| */ | ||
| PolynomialArray PolynomialArray::drop() const { |
There was a problem hiding this comment.
Currently this method is not used. I was using it when I was converting the underlying public key ciphertext from a higher modulus to a lower modulus, but the current implementation (using first_context_data instead of key_context_data already does this drop for us). Leaving this here in case we need it later. I have a test in Rust that ensures it does the correct thing.
rickwebiii
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public keys were always stored in NTT form, and hence need to be converted out of that form in order to use them with other components that are also not in NTT form.
Additionally adds a predicate to determine if a public key is in NTT form. This should always be true but can be a good check to ensure that if the public key is converted at any point that it should be returned back to NTT form.