Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework fix for retrieving storage details #57

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Framework fix for retrieving storage details #57

merged 1 commit into from
Sep 28, 2020

Conversation

sowmya-dixit
Copy link
Collaborator

AppConf.getConfig(storageKey) - here storageKey will just have azure as value. This fails for empty keys.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

anandp504
anandp504 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@anandp504 anandp504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@anandp504 anandp504 merged commit ebd55e0 into Sunbird-Obsrv:release-3.3.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandp504 anandp504 anandp504 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sowmya-dixit @anandp504