Repository navigation
test: synchronize timed send-batch deadline assertions - #794
Merged
Merged
Conversation
Replace this manually timed test's polling and independent read timeout with cancellation-aware semantic barriers. Cover deferred reader scheduling and assert the original deadline, exact ordered frames, one timed flush, and resource cleanup. Refs #387
SunSi12138
marked this pull request as ready for review
October 9, 2026 11:50
Owner
Author
|
Ready-for-review verification is complete for
The PR remains the reviewed one-file test change. This addresses the timed-batch test-observation weakness; the original macOS interleaving remains unproven. Refs #387; the umbrella issue remains open. |
26 of 33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Refs #387.
This addresses the
TimedBatchShouldExtendBatchForFrameArrivingBeforeDeadlinesubcase only. The reported macOS failure reached the output read after both provider timer-arm observations, then expired its independent two-second wall-clock guard. That log does not establish the original scheduler interleaving or a production SendPump/WakeupSignal defect.Changes
Only the test and its private helpers change. No production change, timeout increase, retry or skip.
Validation
Hosted validation for
e5695f153d897e7173ad3635113c4d642f13ec94Hosted CI resolves the local sandbox's full-unit and solution-format limitations. The controlled delayed-reader and cancellation-cleanup experiments remain test-harness evidence; they do not establish the original macOS failure's exact cause.
The umbrella issue stays open for its other subcases.