Skip to content

perf(abstractions): shrink RpcMethodDescriptor from 40 to 32 bytes #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunSi12138 merged 3 commits into from
Oct 9, 2026
Merged

perf(abstractions): shrink RpcMethodDescriptor from 40 to 32 bytes #752

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d752bcc
perf(abstractions): shrink RpcMethodDescriptor from 40 to 32 bytes
SunSi12138 Sep 25, 2026
dd80dfc
fix(abstractions): preserve nullable RPC timeout semantics at 32 bytes
SunSi12138 Oct 9, 2026
75e1908
test(abstractions): preserve timeout through combined with flag updates
SunSi12138 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/SharpLink.Abstractions/IRpcChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,23 @@ public RpcMethodDescriptor(
public long ContractId { get; init; }
/// <summary>Gets the stable generated method identifier.</summary>
public long MethodId { get; init; }
// Declared ahead of the 4-byte and 1-byte members below. The struct uses sequential layout,
// so a long declared after them would be padded back to an 8-byte boundary and the descriptor
// would stay 40 bytes wide however the timeout were stored.
private readonly long _methodTimeoutTicks;

/// <summary>Gets the explicit method timeout, or <see langword="null"/> to use the client default.</summary>
public TimeSpan? MethodTimeout { get; init; }
/// <remarks>
/// Persisted as a tick count with a negative sentinel rather than as
/// <see cref="Nullable{T}"/> of <see cref="TimeSpan"/>. The nullable form occupies 16 bytes and
/// padded the descriptor to 40; one 8-byte field keeps it at 32. The descriptor is passed by
/// value through every client invocation boundary, so its width is on the hot path.
/// </remarks>
public TimeSpan? MethodTimeout
{
get => _methodTimeoutTicks < 0 ? null : TimeSpan.FromTicks(_methodTimeoutTicks);
Comment thread
SunSi12138 marked this conversation as resolved.
Resolved
init => _methodTimeoutTicks = value?.Ticks ?? NoMethodTimeoutTicks;
}
/// <summary>Gets the number of client-stream parameters owned by the request.</summary>
public int ClientStreamCount { get; init; }
/// <summary>Gets the generated invocation shape.</summary>
Expand Down Expand Up @@ -105,6 +120,8 @@ public bool ResponseNullable
init => _flags = SetFlag(_flags, ResponseNullableFlag, value);
}

private const long NoMethodTimeoutTicks = -1;

private readonly byte _flags;

private static byte SetFlag(byte flags, byte flag, bool value)
Expand Down
Loading